You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/02/16 02:58:07 UTC
[GitHub] [iceberg-docs] amogh-jahagirdar opened a new pull request #56: Docs: Patch documentation for 0.13.1 release
amogh-jahagirdar opened a new pull request #56:
URL: https://github.com/apache/iceberg-docs/pull/56
In this change we are patching some docs recently updated as part of the 0.13.1 release.
1.) Fix the link for the runtime jar for spark, in the getting started page
2.) Moving details like IDE setup and benchmarking to the new contributing page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] jackye1995 merged pull request #56: Docs: Patch documentation for 0.13.1 release
Posted by GitBox <gi...@apache.org>.
jackye1995 merged pull request #56:
URL: https://github.com/apache/iceberg-docs/pull/56
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] jackye1995 commented on pull request #56: Docs: Patch documentation for 0.13.1 release
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #56:
URL: https://github.com/apache/iceberg-docs/pull/56#issuecomment-1041056305
Thanks for the fix! @amogh-jahagirdar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] jackye1995 commented on a change in pull request #56: Docs: Patch documentation for 0.13.1 release
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on a change in pull request #56:
URL: https://github.com/apache/iceberg-docs/pull/56#discussion_r807496440
##########
File path: landing-page/content/common/community/contribute.md
##########
@@ -163,6 +172,12 @@ When passing boolean arguments to existing or external methods, use inline comme
2. Use `.` to create a hierarchy of config groups
* For example, `s3` in `s3.access-key-id`, `s3.secret-access-key`
+## Running Benchmarks
+Some PRs/changesets might require running benchmarks to determine whether they are affecting the baseline performance. Currently there is
+no "push a single button to get a performance comparison" solution available, therefore one has to run JMH performance tests on their local machine and
+post the results on the PR.
+
+See [Benchmarks](../benchmarks) for a summary of available benchmarks and how to run them.
Review comment:
nit: newline before new section
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org