You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/12/09 16:33:17 UTC
[GitHub] [trafficcontrol] rawlinp opened a new issue #6411: Traffic Portal should filter out the "ALL" CDN option for snapshotting and queuing updates
rawlinp opened a new issue #6411:
URL: https://github.com/apache/trafficcontrol/issues/6411
<!--
************ STOP!! ************
If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
- For *SUPPORT QUESTIONS*, use the #traffic-control channel on the ASF slack (https://s.apache.org/tc-slack-request)
or the Traffic Control Users mailing list (send an email to users-subscribe@trafficcontrol.apache.org to subscribe).
- Before submitting, please **SEARCH GITHUB** for a similar issue or PR
* https://github.com/apache/trafficcontrol/issues
* https://github.com/apache/trafficcontrol/pulls
-->
<!-- Do not submit security vulnerabilities or support requests here - see above -->
## This Improvement request (usability, performance, tech debt, etc.) affects these Traffic Control components:
<!-- delete all those that don't apply -->
- Traffic Portal
## Current behavior:
<!-- Describe how the current features are insufficient. -->
When snapshotting or queuing updates in Traffic Portal, the `ALL` CDN is listed as an option:
## New behavior:
<!-- Describe how this change would improve Traffic Control -->
The `ALL` CDN should not be listed as an option in the snapshot and queue update modals, because it is never valid to snapshot or queue updates for the `ALL` CDN.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp closed issue #6411: Traffic Portal should filter out the "ALL" CDN option for snapshotting and queuing updates
Posted by GitBox <gi...@apache.org>.
rawlinp closed issue #6411:
URL: https://github.com/apache/trafficcontrol/issues/6411
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on issue #6411: Traffic Portal should filter out the "ALL" CDN option for snapshotting and queuing updates
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #6411:
URL: https://github.com/apache/trafficcontrol/issues/6411#issuecomment-997042611
in addition. on the ALL cdn page (https://tp.domain.tld/#!/cdns/{{all_cdn_id}}), those options should not exist:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp commented on issue #6411: Traffic Portal should filter out the "ALL" CDN option for snapshotting and queuing updates
Posted by GitBox <gi...@apache.org>.
rawlinp commented on issue #6411:
URL: https://github.com/apache/trafficcontrol/issues/6411#issuecomment-998032570
@ocket8888 I agree with your sentiments about the `ALL` CDN, but I do also think it's worth it to treat it specially in certain cases until such a time that we can separate cache servers from non-cache servers, especially since this does seem like a UI regression like @mitchell852 said.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on issue #6411: Traffic Portal should filter out the "ALL" CDN option for snapshotting and queuing updates
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #6411:
URL: https://github.com/apache/trafficcontrol/issues/6411#issuecomment-997053532
If we really want to treat ALL specially, then we need to make that more formal. It should be immutable, it shouldn't be allowed to contain Delivery Services, etc. Currently, there are some places that treat ALL specially, and some that don't, and it can lead you to a partly correct configuration. It's also not documented anywhere that ALL is special and shouldn't be used for certain things.
IMO, we should actually just _not_ treat ALL specially, and get rid of the notion of some special CDN that isn't really a CDN but sometimes is. If servers don't belong to a CDN, then they can just have `null` CDNs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #6411: Traffic Portal should filter out the "ALL" CDN option for snapshotting and queuing updates
Posted by GitBox <gi...@apache.org>.
mitchell852 edited a comment on issue #6411:
URL: https://github.com/apache/trafficcontrol/issues/6411#issuecomment-997057676
> IMO, we should actually just _not_ treat ALL specially, and get rid of the notion of some special CDN that isn't really a CDN but sometimes is. If servers don't belong to a CDN, then they can just have `null` CDNs.
sure but that's a bigger effort and would require some thought on the plan. for now, i'll hide the ALL cdn from operations it was not designed to support as it was before. PR coming...this is a regression bug that was introduced when i added cdn notifications and decided to use the ALL cdn for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #6411: Traffic Portal should filter out the "ALL" CDN option for snapshotting and queuing updates
Posted by GitBox <gi...@apache.org>.
mitchell852 edited a comment on issue #6411:
URL: https://github.com/apache/trafficcontrol/issues/6411#issuecomment-997057676
> IMO, we should actually just _not_ treat ALL specially, and get rid of the notion of some special CDN that isn't really a CDN but sometimes is. If servers don't belong to a CDN, then they can just have `null` CDNs.
sure but that's a bigger effort and would require some thought on the plan. for now, i'll hide the ALL cdn from operations it was not designed to support as it was before. PR coming...this is a regression bug that was introduced when i added cdn notifications and decided to use the ALL cdn for that. i would definitely welcome the removal of the ALL cdn #3355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 edited a comment on issue #6411: Traffic Portal should filter out the "ALL" CDN option for snapshotting and queuing updates
Posted by GitBox <gi...@apache.org>.
mitchell852 edited a comment on issue #6411:
URL: https://github.com/apache/trafficcontrol/issues/6411#issuecomment-997057676
> IMO, we should actually just _not_ treat ALL specially, and get rid of the notion of some special CDN that isn't really a CDN but sometimes is. If servers don't belong to a CDN, then they can just have `null` CDNs.
sure but that's a bigger effort and would require some thought on the plan. for now, i'll hide the ALL cdn from operations it was not designed to support as it was before. PR coming...pretty sure this is a regression bug that was introduced when i added cdn notification and decided to use the ALL cdn for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on issue #6411: Traffic Portal should filter out the "ALL" CDN option for snapshotting and queuing updates
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #6411:
URL: https://github.com/apache/trafficcontrol/issues/6411#issuecomment-997041557
that's odd. i don't recall it doing that...but indeed it does. feels like a regression bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on issue #6411: Traffic Portal should filter out the "ALL" CDN option for snapshotting and queuing updates
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #6411:
URL: https://github.com/apache/trafficcontrol/issues/6411#issuecomment-997057676
> IMO, we should actually just _not_ treat ALL specially, and get rid of the notion of some special CDN that isn't really a CDN but sometimes is. If servers don't belong to a CDN, then they can just have `null` CDNs.
sure but that's a bigger effort and would require some thought on the plan. for now, i'll hide the ALL cdn from operations it was not designed to support. PR coming...pretty sure this is a regression bug that was introduced when i added cdn notification and decided to use the ALL cdn for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org