You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@devlake.apache.org by "warren830 (via GitHub)" <gi...@apache.org> on 2023/01/31 04:32:44 UTC
[GitHub] [incubator-devlake-helm-chart] warren830 opened a new pull request, #68: test(ci): add ci to check image version and chart version
warren830 opened a new pull request, #68:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/68
add ci to check if image versions are equal to chart version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] matrixji commented on pull request #68: test(ci): add ci to check image version and chart version
Posted by "matrixji (via GitHub)" <gi...@apache.org>.
matrixji commented on PR #68:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/68#issuecomment-1409758300
`if [[ $chart_version_text != $devlake_version_text ]]` should be `if [[ v$chart_version_text != $devlake_version_text ]]`
The image tag have a leading `v` character, while the chart version follows [SemVer 2 standard](https://semver.org/spec/v2.0.0.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] warren830 commented on pull request #68: test(ci): add ci to check image version and chart version
Posted by "warren830 (via GitHub)" <gi...@apache.org>.
warren830 commented on PR #68:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/68#issuecomment-1409801584
> > >
> >
> >
> > I just checked we have a leading `v` in `version`, do you think we should delete that `v`? Or we can keep this the same to the image tag?
>
> Yes, we have a `v` prefix in `Chart.yaml`, it seems work correctly right now, but as the spec says helm use SemVer 2 for `version` field, we'd better remove it in `Chart.yaml`, later I may add some python scripts in pipeline to check it.
Thanks! So do we still need to merge this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] warren830 commented on pull request #68: test(ci): add ci to check image version and chart version
Posted by "warren830 (via GitHub)" <gi...@apache.org>.
warren830 commented on PR #68:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/68#issuecomment-1409802010
> `if [[ $chart_version_text != $devlake_version_text ]]` should be `if [[ v$chart_version_text != $devlake_version_text ]]`
>
> The image tag have a leading `v` character, while the chart version follows [SemVer 2 standard](https://semver.org/spec/v2.0.0.html) which not leading with `v`.
Already fixed this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] matrixji merged pull request #68: test(ci): add ci to check image version and chart version
Posted by "matrixji (via GitHub)" <gi...@apache.org>.
matrixji merged PR #68:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/68
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] warren830 commented on pull request #68: test(ci): add ci to check image version and chart version
Posted by "warren830 (via GitHub)" <gi...@apache.org>.
warren830 commented on PR #68:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/68#issuecomment-1409776018
>
I just checked we have a leading `v` in `version`, do you think we should delete that `v`? Or we can keep this the same to the image tag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] matrixji commented on pull request #68: test(ci): add ci to check image version and chart version
Posted by "matrixji (via GitHub)" <gi...@apache.org>.
matrixji commented on PR #68:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/68#issuecomment-1409791572
> >
>
> I just checked we have a leading `v` in `version`, do you think we should delete that `v`? Or we can keep this the same to the image tag?
Yes, we have a `v` prefix in `Chart.yaml`, it seems work correctly right now, but as the spec says helm use SemVer 2 for `version` field, we'd better remove it in `Chart.yaml`, later I may add some python scripts in pipeline to check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] matrixji commented on pull request #68: test(ci): add ci to check image version and chart version
Posted by "matrixji (via GitHub)" <gi...@apache.org>.
matrixji commented on PR #68:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/68#issuecomment-1409841421
/lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org