You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Josh Elser (JIRA)" <ji...@apache.org> on 2017/02/22 21:08:44 UTC

[jira] [Commented] (CALCITE-1654) Serialized messages are generated even though they are not logged

    [ https://issues.apache.org/jira/browse/CALCITE-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879235#comment-15879235 ] 

Josh Elser commented on CALCITE-1654:
-------------------------------------

Put up a pull-request with the trivial change.. https://github.com/apache/calcite/pull/380

> Serialized messages are generated even though they are not logged
> -----------------------------------------------------------------
>
>                 Key: CALCITE-1654
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1654
>             Project: Calcite
>          Issue Type: Bug
>          Components: avatica
>            Reporter: Sergey Soldatov
>            Assignee: Josh Elser
>            Priority: Critical
>             Fix For: avatica-1.10.0
>
>
> [~sergey.soldatov] made a good find through some careful log reading.
> In ProtobufTranslationImpl, some TRACE logging that I had added in CALCITE-1159 is causing a bunch of garbage to be created on the heap.
> The trace logging messages should be wrapped in a conditionals to avoid the generation of the message itself. I was a little too overzealous thinking that the slf4j api was saving me.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)