[GitHub] [spark] fqaiser94 commented on a change in pull request #27066: [SPARK-31317][SQL] Add withField method to Column

[GitBox <gi...@apache.org>]

fqaiser94 commented on a change in pull request #27066:
URL: https://github.com/apache/spark/pull/27066#discussion_r439103364



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
##########
@@ -539,3 +541,90 @@ case class StringToMap(text: Expression, pairDelim: Expression, keyValueDelim: E
 
   override def prettyName: String = "str_to_map"
 }
+
+/**
+ * Adds/replaces field in struct by name.
+ */
+case class WithField(structExpr: Expression, fieldName: String, valueExpr: Expression)
+  extends Unevaluable {
+
+  private lazy val fieldPath = CatalystSqlParser.parseMultipartIdentifier(fieldName)
+
+  lazy val toCreateNamedStruct: Expression = toCreateNamedStruct(structExpr, fieldPath)
+
+  override def children: Seq[Expression] = Seq(structExpr, valueExpr)
+
+  override def dataType: StructType = toCreateNamedStruct.dataType.asInstanceOf[StructType]
+
+  override def foldable: Boolean = toCreateNamedStruct.foldable
+
+  override def nullable: Boolean = toCreateNamedStruct.nullable
+
+  override def prettyName: String = "with_field"
+
+  override def checkInputDataTypes(): TypeCheckResult = {
+    if (fieldName == null) {
+      TypeCheckResult.TypeCheckFailure("fieldName argument should not be null.")
+    } else if (fieldName.isEmpty) {
+      TypeCheckResult.TypeCheckFailure("fieldName argument should not be empty.")
+    } else {
+      checkIntermediateDataTypesAreStruct(structExpr.dataType, fieldPath)
+    }
+  }
+
+  private val resolver = SQLConf.get.resolver
+
+  private def checkIntermediateDataTypesAreStruct(
+    dataType: DataType,

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org