You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Harsh J (JIRA)" <ji...@apache.org> on 2012/04/27 09:09:51 UTC
[jira] [Created] (HADOOP-8323) Revert HADOOP-7940
Harsh J created HADOOP-8323:
-------------------------------
Summary: Revert HADOOP-7940
Key: HADOOP-8323
URL: https://issues.apache.org/jira/browse/HADOOP-8323
Project: Hadoop Common
Issue Type: Bug
Components: io
Affects Versions: 2.0.0
Reporter: Harsh J
Assignee: Harsh J
Priority: Critical
Per [~jdonofrio]'s comments on HADOOP-7940, we should revert it as it has caused a performance regression (for scenarios where Text is reused, popular in MR).
The clear() works as intended, as the API also offers a current length API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (HADOOP-8323) Revert HADOOP-7940
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J reopened HADOOP-8323:
-----------------------------
> Revert HADOOP-7940
> ------------------
>
> Key: HADOOP-8323
> URL: https://issues.apache.org/jira/browse/HADOOP-8323
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 2.0.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Critical
>
> Per [~jdonofrio]'s comments on HADOOP-7940, we should revert it as it has caused a performance regression (for scenarios where Text is reused, popular in MR).
> The clear() works as intended, as the API also offers a current length API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HADOOP-8323) Revert HADOOP-7940
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J resolved HADOOP-8323.
-----------------------------
Resolution: Won't Fix
Target Version/s: (was: 3.0.0, 2.0.0)
Actually, I looked at the API and this would only impact the Text usage iff clear() is called upon it. I do not think we should revert this. Clear must work as intended - and clear the byte array states inside. There wouldn't be any other way to free the memory if we didn't do this.
I do not see clear() being used in MR directly. So the largest length is still maintained but thats not an issue (except that clear may be called for memory gains if the user wants that).
I'm resolving this as Won't Fix (Won't revert). But if I've missed addressing something, please reopen.
> Revert HADOOP-7940
> ------------------
>
> Key: HADOOP-8323
> URL: https://issues.apache.org/jira/browse/HADOOP-8323
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 2.0.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Critical
>
> Per [~jdonofrio]'s comments on HADOOP-7940, we should revert it as it has caused a performance regression (for scenarios where Text is reused, popular in MR).
> The clear() works as intended, as the API also offers a current length API.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira