You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "crafcat7 (via GitHub)" <gi...@apache.org> on 2023/02/22 17:13:59 UTC
[GitHub] [nuttx] crafcat7 opened a new pull request, #8623: include/signal.h:Expanding SIGNAL to be consistent with Linux
crafcat7 opened a new pull request, #8623:
URL: https://github.com/apache/nuttx/pull/8623
## Summary
Expanding SIGNAL to be consistent with Linux
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] slorquet commented on pull request #8623: include/signal.h:Expanding SIGNAL to be consistent with Linux
Posted by "slorquet (via GitHub)" <gi...@apache.org>.
slorquet commented on PR #8623:
URL: https://github.com/apache/nuttx/pull/8623#issuecomment-1460040475
dont you believe me?
```
CC: string/lib_strsignal.c string/lib_strsignal.c: In function 'strsignal':
string/lib_strsignal.c:169:7: error: duplicate case value
169 | case SIGWORK:
| ^~~~
string/lib_strsignal.c:117:7: note: previously used here
117 | case SIGCHLD:
| ^~~~
```
The problem is that SIGWORK was changed recently from 17 to 31 and my config kept that.
I cant be the only person in this situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] crafcat7 commented on pull request #8623: include/signal.h:Expanding SIGNAL to be consistent with Linux
Posted by "crafcat7 (via GitHub)" <gi...@apache.org>.
crafcat7 commented on PR #8623:
URL: https://github.com/apache/nuttx/pull/8623#issuecomment-1460028640
>
https://github.com/apache/nuttx/blob/47ce89f757bd7767124fbe0a88cfc8e76e68c147/include/signal.h#L222-L226
https://github.com/apache/nuttx/blob/47ce89f757bd7767124fbe0a88cfc8e76e68c147/include/signal.h#L308-L314
In actual definition SIGCHLD is 17 and SIGWORK is 31.
https://github.com/apache/nuttx/blob/47ce89f757bd7767124fbe0a88cfc8e76e68c147/sched/Kconfig#L1557-L1563
https://github.com/apache/nuttx/blob/47ce89f757bd7767124fbe0a88cfc8e76e68c147/sched/Kconfig#L1660-L1667
And the two values ββββare not the same in Kconfig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8623: include/signal.h:Expanding SIGNAL to be consistent with Linux
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #8623:
URL: https://github.com/apache/nuttx/pull/8623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8623: include/signal.h:Expanding SIGNAL to be consistent with Linux
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #8623:
URL: https://github.com/apache/nuttx/pull/8623#issuecomment-1460584064
> dont you believe me?
>
> ```
> CC: string/lib_strsignal.c string/lib_strsignal.c: In function 'strsignal':
> string/lib_strsignal.c:169:7: error: duplicate case value
> 169 | case SIGWORK:
> | ^~~~
> string/lib_strsignal.c:117:7: note: previously used here
> 117 | case SIGCHLD:
> | ^~~~
> ```
>
> The problem is that SIGWORK was changed recently from 17 to 31 and my config kept that.
>
> I cant be the only person in this situation.
so do you use the expend form of defconfig?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] Donny9 commented on pull request #8623: include/signal.h:Expanding SIGNAL to be consistent with Linux
Posted by "Donny9 (via GitHub)" <gi...@apache.org>.
Donny9 commented on PR #8623:
URL: https://github.com/apache/nuttx/pull/8623#issuecomment-1460062543
>
hello, what is the value of CONFIG_SIG_CHLD and CONFIG_SIG_SIGWORK of your board?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8623: include/signal.h:Expanding SIGNAL to be consistent with Linux
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #8623:
URL: https://github.com/apache/nuttx/pull/8623#discussion_r1115292117
##########
include/signal.h:
##########
@@ -211,41 +206,96 @@
# define SIGPIPE CONFIG_SIG_PIPE
#endif
-#ifndef CONFIG_SIG_HUP
-# define SIGHUP 14
+#ifndef CONFIG_SIG_ALRM
+# define SIGALRM 14 /* Default signal used with POSIX timers (used only */
+ /* no other signal is provided) */
#else
-# define SIGHUP CONFIG_SIG_HUP
+# define SIGALRM CONFIG_SIG_ALRM
+#endif
+
+#ifndef CONFIG_SIG_TERM
+# define SIGTERM 15
+#else
+# define SIGTERM CONFIG_SIG_TERM
+#endif
+
+#ifndef CONFIG_SIG_CHLD
+# define SIGCHLD 17
+#else
+# define SIGCHLD CONFIG_SIG_CHLD
+#endif
+
+#ifndef CONFIG_SIG_CONT
+# define SIGCONT 18
+#else
+# define SIGCONT CONFIG_SIG_CONT
+#endif
+
+#ifndef CONFIG_SIG_STOP
+# define SIGSTOP 19
+#else
+# define SIGSTOP CONFIG_SIG_STOP
+#endif
+
+#ifndef CONFIG_SIG_TSTP
+# define SIGTSTP 20
+#else
+# define SIGTSTP CONFIG_SIG_TSTP
#endif
#ifndef CONFIG_SIG_TTIN
-# define SIGTTIN 15
+# define SIGTTIN 21
#else
# define SIGTTIN CONFIG_SIG_TTIN
#endif
-#ifndef CONFIG_SIG_FPE
-# define SIGFPE 16
+#ifndef CONFIG_SIG_TTOU
+# define SIGTTOU 22
#else
-# define SIGFPE CONFIG_SIG_FPE
+# define SIGTTOU CONFIG_SIG_TTOU
#endif
-#ifndef CONFIG_SIG_ILL
-# define SIGILL 17
+#ifndef CONFIG_SIG_URG
+# define SIGURG 23
#else
-# define SIGILL CONFIG_SIG_ILL
+# define SIGURG CONFIG_SIG_URG
#endif
-#ifndef CONFIG_SIG_SEGV
-# define SIGSEGV 18
+#ifndef CONFIG_SIG_XCPU
+# define SIGXCPU 24
#else
-# define SIGSEGV CONFIG_SIG_SEGV
+# define SIGXCPU CONFIG_SIG_XCPU
+#endif
+
+#ifndef CONFIG_SIG_XFSZ
+# define SIGXFSZ 25
+#else
+# define SIGXFSZ CONFIG_SIG_XFSZ
+#endif
+
+#ifndef CONFIG_SIG_VTALRM
+# define SIGVTALRM 26
+#else
+# define SIGVTALRM CONFIG_SIG_VTALRM
+#endif
+
+#ifndef CONFIG_SIG_PROF
+# define SIGPROF 27
+#else
+# define SIGPROF CONFIG_SIG_PROF
+#endif
+
+#ifndef CONFIG_SIG_POLL
+# define SIGPOLL 29
+#else
+# define SIGPOLL CONFIG_SIG_POLL
#endif
Review Comment:
#define SIGIO SIGPOLL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] slorquet commented on pull request #8623: include/signal.h:Expanding SIGNAL to be consistent with Linux
Posted by "slorquet (via GitHub)" <gi...@apache.org>.
slorquet commented on PR #8623:
URL: https://github.com/apache/nuttx/pull/8623#issuecomment-1459998578
duplicate switch case because SIGCHLD ==SIGWORK
when CONFIG_SCHED_HAS_PARENT SIGCHLD is forced to 17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8623: include/signal.h:Expanding SIGNAL to be consistent with Linux
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #8623:
URL: https://github.com/apache/nuttx/pull/8623#issuecomment-1461351295
> I save the current .config as my defconfig, so it contains all parameters. This way I am sure that the configuration is stable.
>
Ok, that is why the main CI doesn't hit the similar problem since all defconfig in boards save in the normalize form.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] crafcat7 commented on pull request #8623: include/signal.h:Expanding SIGNAL to be consistent with Linux
Posted by "crafcat7 (via GitHub)" <gi...@apache.org>.
crafcat7 commented on PR #8623:
URL: https://github.com/apache/nuttx/pull/8623#issuecomment-1459987793
> Careful with CONFIG_SCHED_HAS_PARENT
>
> This code breaks my build because this config is not set.
What is the specific error report? This is the SIGNAL implemented according to https://pubs.opengroup.org/onlinepubs/009695399/basedefs/signal.h.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] slorquet commented on pull request #8623: include/signal.h:Expanding SIGNAL to be consistent with Linux
Posted by "slorquet (via GitHub)" <gi...@apache.org>.
slorquet commented on PR #8623:
URL: https://github.com/apache/nuttx/pull/8623#issuecomment-1460042336
It was changed here from 20 to 31
https://github.com/apache/nuttx/commit/e6227e19433c4999d500437d0a8a5c05f476ceb1#diff-285d196ad580d55fdaef3fbe54702ee3ddeed0d93cba52a5441d1866e0031726L1584
The comment still shows that it was previously changed from 17 to 20
This is very messy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] slorquet commented on pull request #8623: include/signal.h:Expanding SIGNAL to be consistent with Linux
Posted by "slorquet (via GitHub)" <gi...@apache.org>.
slorquet commented on PR #8623:
URL: https://github.com/apache/nuttx/pull/8623#issuecomment-1458289191
This was not reviewed before merging, why?
Also this breaks if CONFIG_SCHED_HAS_PARENT is not defined because SIGCHLD will collide with the new values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] slorquet commented on pull request #8623: include/signal.h:Expanding SIGNAL to be consistent with Linux
Posted by "slorquet (via GitHub)" <gi...@apache.org>.
slorquet commented on PR #8623:
URL: https://github.com/apache/nuttx/pull/8623#issuecomment-1460831841
I save the current .config as my defconfig, so it contains all parameters.
This way I am sure that the configuration is stable.
@Donny9 hi, it was stuck at 17 because I keep full configs.
This specific situation is hard to track down.
There is no real way to update a full .config file with updated default values, so this is unavoidable.
TBH this is a minor problem with a complex cause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org