You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/18 20:54:48 UTC
[GitHub] [airflow] blag opened a new pull request #22369: Use Airflow's compat layer for cached_property
blag opened a new pull request #22369:
URL: https://github.com/apache/airflow/pull/22369
Instead of checking the Python version in every provider, we can simply use Airflow's compat module to import `cached_property`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #22369: Use Airflow's compat layer for cached_property
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #22369:
URL: https://github.com/apache/airflow/pull/22369#issuecomment-1072862216
I believe we can't (yet)
`airflow.compat.functools` introduced in Airflow 2.2
minimum Airflow version for providers is Airflow 2.1 so merging this PR means bumping minimum Airflow version for providers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] blag commented on pull request #22369: Use Airflow's compat layer for cached_property
Posted by GitBox <gi...@apache.org>.
blag commented on pull request #22369:
URL: https://github.com/apache/airflow/pull/22369#issuecomment-1072969793
Sounds good. 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22369: Use Airflow's compat layer for cached_property
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22369:
URL: https://github.com/apache/airflow/pull/22369#issuecomment-1072897649
Yep. We should close it and reopen in May when we migrate to 2.2 as min-version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] blag closed pull request #22369: Use Airflow's compat layer for cached_property
Posted by GitBox <gi...@apache.org>.
blag closed pull request #22369:
URL: https://github.com/apache/airflow/pull/22369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org