You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/06/08 05:20:13 UTC
[GitHub] [ozone] kerneltime opened a new pull request #2311: HDDS-5315 Skip storing unwanted block tokens on OM DB
kerneltime opened a new pull request #2311:
URL: https://github.com/apache/ozone/pull/2311
## What changes were proposed in this pull request?
Block tokens do not need to be stored in OM DB.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5315
## How was this patch tested?
- [ ] Replace jar in a testbed and check keys stored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on pull request #2311: HDDS-5315 Skip storing unwanted block tokens on OM DB
Posted by GitBox <gi...@apache.org>.
kerneltime commented on pull request #2311:
URL: https://github.com/apache/ozone/pull/2311#issuecomment-859808505
Unit test PR: https://github.com/apache/ozone/pull/2329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] xiaoyuyao commented on pull request #2311: HDDS-5315 Skip storing unwanted block tokens on OM DB
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on pull request #2311:
URL: https://github.com/apache/ozone/pull/2311#issuecomment-859163327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on pull request #2311: HDDS-5315 Skip storing unwanted block tokens on OM DB
Posted by GitBox <gi...@apache.org>.
kerneltime commented on pull request #2311:
URL: https://github.com/apache/ozone/pull/2311#issuecomment-857318097
> Thanks @kerneltime for working on this. PR LGTM. Can you add a unit test by create a key with a client then get key and verify token is not there in the returned key location infos?
Yup makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] github-actions[bot] commented on pull request #2311: HDDS-5315 Skip storing unwanted block tokens on OM DB
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #2311:
URL: https://github.com/apache/ozone/pull/2311#issuecomment-859163450
No such command. `recheck
` Available commands:
* /**close** : Close pending pull request temporary
* /**help** : Show all the available comment commands
* /**label** : add new label to the issue: `/label <label>`
* /**pending** : Add a REQUESTED_CHANGE type review to mark issue non-mergeable: `/pending <reason>`
* /**ready** : Dismiss all the blocking reviews by github-actions bot
* /**retest** : provide help on how to trigger new CI build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on pull request #2311: HDDS-5315 Skip storing unwanted block tokens on OM DB
Posted by GitBox <gi...@apache.org>.
kerneltime commented on pull request #2311:
URL: https://github.com/apache/ozone/pull/2311#issuecomment-859132733
`testSetNodeOpStateAndCommandFired` runs fine locally, not sure why it failed in CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] xiaoyuyao commented on pull request #2311: HDDS-5315 Skip storing unwanted block tokens on OM DB
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on pull request #2311:
URL: https://github.com/apache/ozone/pull/2311#issuecomment-856939394
Thanks @kerneltime for working on this. PR LGTM. Can you add a unit test by create a key with a client then get key and verify token is not there in the returned key location infos?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] xiaoyuyao merged pull request #2311: HDDS-5315 Skip storing unwanted block tokens on OM DB
Posted by GitBox <gi...@apache.org>.
xiaoyuyao merged pull request #2311:
URL: https://github.com/apache/ozone/pull/2311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org