[GitHub] [kafka] hachikuji commented on a change in pull request #8664: KAFKA-9716: Clarify meaning of compression rate metrics

[GitBox <gi...@apache.org>]

hachikuji commented on a change in pull request #8664:
URL: https://github.com/apache/kafka/pull/8664#discussion_r436403864



##########
File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/SenderMetricsRegistry.java
##########
@@ -84,7 +84,7 @@ public SenderMetricsRegistry(Metrics metrics) {
         this.batchSizeMax = createMetricName("batch-size-max",
                 "The max number of bytes sent per partition per-request.");
         this.compressionRateAvg = createMetricName("compression-rate-avg",
-                "The average compression rate of record batches.");
+                "The average compressed-to-uncompressed size ratio of record batches.");

Review comment:
       It might be a little more verbose, but perhaps we could phrase it like this?
   ```
   The average compression rate of record batches, defined as the average ratio of the compressed batch size over the uncompressed size.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org