You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ksakellis <gi...@git.apache.org> on 2014/12/16 20:08:53 UTC

[GitHub] spark pull request: [SPARK-4092] [CORE] Fix InputMetrics for coale...

Github user ksakellis commented on the pull request:

    https://github.com/apache/spark/pull/3120#issuecomment-67213648
  
    @kayousterhout The test you pointed out:
    sc.parallelize(1 to 2).saveAsTextFile("file:////tester1")
    val a = sc.textFile("file:////tester1")
    sc.parallelize(1 to 10).saveAsTextFile("file:////tester2")
    val b = sc.textFile("file:////tester2")
    a.cartesian(b)
    b.cartesian(a)
    
    is actually not valid because of how cartesian is implemented. I added a comment to the interleaved reads unit test to describe the reasoning.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org