You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by is...@apache.org on 2021/10/13 20:32:17 UTC
[ignite] branch master updated: IGNITE-15688: Add close() to
IgniteClient.
This is an automated email from the ASF dual-hosted git repository.
isapego pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ignite.git
The following commit(s) were added to refs/heads/master by this push:
new 3a9b565 IGNITE-15688: Add close() to IgniteClient.
3a9b565 is described below
commit 3a9b5651d7e41136031acba3274bf8f48c763cf4
Author: stanlukyanov <st...@gmail.com>
AuthorDate: Wed Oct 13 22:31:13 2021 +0200
IGNITE-15688: Add close() to IgniteClient.
This closes #9475
---
.../apache/ignite/examples/client/ClientKubernetesPutGetExample.java | 2 +-
.../java/org/apache/ignite/examples/client/ClientPutGetExample.java | 3 ---
.../core/src/main/java/org/apache/ignite/client/IgniteClient.java | 5 +++++
.../java/org/apache/ignite/internal/client/thin/TcpIgniteClient.java | 2 +-
.../src/main/java/org/apache/ignite/IgniteClientSpringBean.java | 2 +-
5 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/examples/src/main/java/org/apache/ignite/examples/client/ClientKubernetesPutGetExample.java b/examples/src/main/java/org/apache/ignite/examples/client/ClientKubernetesPutGetExample.java
index 92e669c..8964115 100644
--- a/examples/src/main/java/org/apache/ignite/examples/client/ClientKubernetesPutGetExample.java
+++ b/examples/src/main/java/org/apache/ignite/examples/client/ClientKubernetesPutGetExample.java
@@ -42,7 +42,7 @@ public class ClientKubernetesPutGetExample {
*
* @param args Command line arguments.
*/
- public static void main(String[] args) throws Exception {
+ public static void main(String[] args) {
KubernetesConnectionConfiguration kcfg = new KubernetesConnectionConfiguration();
kcfg.setNamespace("ignite");
diff --git a/examples/src/main/java/org/apache/ignite/examples/client/ClientPutGetExample.java b/examples/src/main/java/org/apache/ignite/examples/client/ClientPutGetExample.java
index d8b14ef..96a8ae4 100644
--- a/examples/src/main/java/org/apache/ignite/examples/client/ClientPutGetExample.java
+++ b/examples/src/main/java/org/apache/ignite/examples/client/ClientPutGetExample.java
@@ -66,8 +66,5 @@ public class ClientPutGetExample {
catch (ClientException e) {
System.err.println(e.getMessage());
}
- catch (Exception e) {
- System.err.format("Unexpected failure: %s\n", e);
- }
}
}
diff --git a/modules/core/src/main/java/org/apache/ignite/client/IgniteClient.java b/modules/core/src/main/java/org/apache/ignite/client/IgniteClient.java
index 8c5b87e..bb94b48 100644
--- a/modules/core/src/main/java/org/apache/ignite/client/IgniteClient.java
+++ b/modules/core/src/main/java/org/apache/ignite/client/IgniteClient.java
@@ -216,4 +216,9 @@ public interface IgniteClient extends AutoCloseable {
* @return {@code Services} functionality over given cluster group.
*/
public ClientServices services(ClientClusterGroup grp);
+
+ /**
+ * Closes this client's open connections and relinquishes all underlying resources.
+ */
+ @Override public void close();
}
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/client/thin/TcpIgniteClient.java b/modules/core/src/main/java/org/apache/ignite/internal/client/thin/TcpIgniteClient.java
index 13e0cd4..13ae567 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/client/thin/TcpIgniteClient.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/client/thin/TcpIgniteClient.java
@@ -155,7 +155,7 @@ public class TcpIgniteClient implements IgniteClient {
}
/** {@inheritDoc} */
- @Override public void close() throws Exception {
+ @Override public void close() {
ch.close();
}
diff --git a/modules/spring/src/main/java/org/apache/ignite/IgniteClientSpringBean.java b/modules/spring/src/main/java/org/apache/ignite/IgniteClientSpringBean.java
index 063c4db..b481820 100644
--- a/modules/spring/src/main/java/org/apache/ignite/IgniteClientSpringBean.java
+++ b/modules/spring/src/main/java/org/apache/ignite/IgniteClientSpringBean.java
@@ -229,7 +229,7 @@ public class IgniteClientSpringBean implements IgniteClient, SmartLifecycle {
}
/** {@inheritDoc} */
- @Override public void close() throws Exception {
+ @Override public void close() {
cli.close();
}