You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2022/05/23 20:40:48 UTC
[GitHub] [orc] loqs opened a new issue, #1138: ThirdpartyToolchain.cmake reversed zlib static library preference
loqs opened a new issue, #1138:
URL: https://github.com/apache/orc/issues/1138
https://github.com/apache/orc/blob/1e2962064b209f1b00188877f08d4226da85c640/cmake_modules/ThirdpartyToolchain.cmake#L147-L151
If ```ORC_PREFER_STATIC_ZLIB``` is false then the static system zlib is used.
If ```ORC_PREFER_STATIC_ZLIB``` is true and ```ZLIB_STATIC_LIB``` is set then the shared system zlib is used.
This usage contradicts the description for ```ORC_PREFER_STATIC_ZLIB``` 'Prefer static zlib library, if available'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on issue #1138: ThirdpartyToolchain.cmake reversed zlib static library preference
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #1138:
URL: https://github.com/apache/orc/issues/1138#issuecomment-1135513135
cc @stiga-huang and @wgtmac too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on issue #1138: ORC-1188: Fix `ORC_PREFER_STATIC_ZLIB`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #1138:
URL: https://github.com/apache/orc/issues/1138#issuecomment-1136547540
Okay, let me make a PR for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on issue #1138: ORC-1188: Fix `ORC_PREFER_STATIC_ZLIB`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #1138:
URL: https://github.com/apache/orc/issues/1138#issuecomment-1135515722
ORC_PREFER_STATIC_ZLIB seems to be added at Apache ORC 1.7.0.
I filed ORC-1188 and set Milestone 1.7.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun closed issue #1138: ORC-1188: Fix `ORC_PREFER_STATIC_ZLIB`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed issue #1138: ORC-1188: Fix `ORC_PREFER_STATIC_ZLIB`
URL: https://github.com/apache/orc/issues/1138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on issue #1138: ThirdpartyToolchain.cmake reversed zlib static library preference
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #1138:
URL: https://github.com/apache/orc/issues/1138#issuecomment-1135261663
Thank you for reporting, @loqs . Do you want to make a PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org