You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Xi Wang <xw...@hortonworks.com> on 2015/04/03 00:40:05 UTC
Review Request 32793: Create Widget wizard: Show threshold and unit
field for a widget type
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32793/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly and Yusaku Sako.
Bugs: AMBARI-10338
https://issues.apache.org/jira/browse/AMBARI-10338
Repository: ambari
Description
-------
Gauge: Threshold*
Number: Threshold, Unit
Graph: Graph Type*, Time Range*, Unit
Template: Unit
'*' field is require.
Non-required field could be empty.
Need validation for each property.
Go to step3, the properties values entered in step2 is in {{controller.content.widgetProperties}}
Diffs
-----
ambari-web/app/controllers/main/service/widgets/create/step2_controller.js 2438a80
ambari-web/app/models.js e9de30f
ambari-web/app/models/widget.js 88a80e3
ambari-web/app/models/widget_property.js PRE-CREATION
ambari-web/app/styles/enhanced_service_dashboard.less 24e52a3
ambari-web/app/templates/main/service/widgets/create/step2.hbs 50f7b86
ambari-web/app/templates/main/service/widgets/create/widget_property_threshold.hbs PRE-CREATION
ambari-web/app/views/main/service/widgets/create/step2_view.js 610e98c
Diff: https://reviews.apache.org/r/32793/diff/
Testing
-------
5771 tests complete (10 seconds)
78 tests pending
Thanks,
Xi Wang
Re: Review Request 32793: Create Widget wizard: Show threshold and
unit field for a widget type
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32793/#review78751
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On April 3, 2015, 12:37 a.m., Xi Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32793/
> -----------------------------------------------------------
>
> (Updated April 3, 2015, 12:37 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
>
>
> Bugs: AMBARI-10338
> https://issues.apache.org/jira/browse/AMBARI-10338
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Gauge: Threshold*
> Number: Threshold, Unit
> Graph: Graph Type*, Time Range*, Unit
> Template: Unit
>
> '*' field is require.
> Non-required field could be empty.
> Need validation for each property.
>
> Go to step3, the properties values entered in step2 is in {{controller.content.widgetProperties}}
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/widgets/create/step2_controller.js 2438a80
> ambari-web/app/models.js e9de30f
> ambari-web/app/models/widget.js 88a80e3
> ambari-web/app/models/widget_property.js PRE-CREATION
> ambari-web/app/styles/enhanced_service_dashboard.less 24e52a3
> ambari-web/app/templates/main/service/widgets/create/step2.hbs 50f7b86
> ambari-web/app/templates/main/service/widgets/create/widget_property_threshold.hbs PRE-CREATION
> ambari-web/app/views/main/service/widgets/create/step2_view.js 610e98c
>
> Diff: https://reviews.apache.org/r/32793/diff/
>
>
> Testing
> -------
>
> 5771 tests complete (10 seconds)
> 78 tests pending
>
>
> Thanks,
>
> Xi Wang
>
>
Re: Review Request 32793: Create Widget wizard: Show threshold and
unit field for a widget type
Posted by Xi Wang <xw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32793/
-----------------------------------------------------------
(Updated April 2, 2015, 5:47 p.m.)
Review request for Ambari, Jaimin Jetly and Yusaku Sako.
Bugs: AMBARI-10338
https://issues.apache.org/jira/browse/AMBARI-10338
Repository: ambari
Description
-------
Gauge: Threshold*
Number: Threshold, Unit
Graph: Graph Type*, Time Range*, Unit
Template: Unit
'*' field is require.
Non-required field could be empty.
Need validation for each property.
Go to step3, the properties values entered in step2 is in {{controller.content.widgetProperties}}
Diffs
-----
ambari-web/app/controllers/main/service/widgets/create/step2_controller.js 2438a80
ambari-web/app/models.js e9de30f
ambari-web/app/models/widget.js 88a80e3
ambari-web/app/models/widget_property.js PRE-CREATION
ambari-web/app/styles/enhanced_service_dashboard.less 24e52a3
ambari-web/app/templates/main/service/widgets/create/step2.hbs 50f7b86
ambari-web/app/templates/main/service/widgets/create/widget_property_threshold.hbs PRE-CREATION
ambari-web/app/views/main/service/widgets/create/step2_view.js 610e98c
Diff: https://reviews.apache.org/r/32793/diff/
Testing (updated)
-------
5771 tests complete (10 seconds)
78 tests pending
5771 tests complete (12 seconds)
78 tests pending
Thanks,
Xi Wang
Re: Review Request 32793: Create Widget wizard: Show threshold and
unit field for a widget type
Posted by Xi Wang <xw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32793/
-----------------------------------------------------------
(Updated April 2, 2015, 5:37 p.m.)
Review request for Ambari, Jaimin Jetly and Yusaku Sako.
Bugs: AMBARI-10338
https://issues.apache.org/jira/browse/AMBARI-10338
Repository: ambari
Description
-------
Gauge: Threshold*
Number: Threshold, Unit
Graph: Graph Type*, Time Range*, Unit
Template: Unit
'*' field is require.
Non-required field could be empty.
Need validation for each property.
Go to step3, the properties values entered in step2 is in {{controller.content.widgetProperties}}
Diffs (updated)
-----
ambari-web/app/controllers/main/service/widgets/create/step2_controller.js 2438a80
ambari-web/app/models.js e9de30f
ambari-web/app/models/widget.js 88a80e3
ambari-web/app/models/widget_property.js PRE-CREATION
ambari-web/app/styles/enhanced_service_dashboard.less 24e52a3
ambari-web/app/templates/main/service/widgets/create/step2.hbs 50f7b86
ambari-web/app/templates/main/service/widgets/create/widget_property_threshold.hbs PRE-CREATION
ambari-web/app/views/main/service/widgets/create/step2_view.js 610e98c
Diff: https://reviews.apache.org/r/32793/diff/
Testing
-------
5771 tests complete (10 seconds)
78 tests pending
Thanks,
Xi Wang
Re: Review Request 32793: Create Widget wizard: Show threshold and
unit field for a widget type
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32793/#review78742
-----------------------------------------------------------
ambari-web/app/models/widget_property.js
<https://reviews.apache.org/r/32793/#comment127737>
Lets rename following variables/functions:
value1 -> warningValue
value2 -> criticalValue
badge1 -> okBadge
badge2 -> warningBadge
badge3 -> criticalBadge
isValid1() -> isWarningValueValid()
isValid2() -> isCriticalValueValid()
ambari-web/app/models/widget_property.js
<https://reviews.apache.org/r/32793/#comment127746>
Also validate:
1. Both values should be positive
2. For Gauge none of the value should be greater than 1.
ambari-web/app/models/widget_property.js
<https://reviews.apache.org/r/32793/#comment127743>
Lets state this as: Warning threshold should be smaller than Critical threshold
- Jaimin Jetly
On April 2, 2015, 10:40 p.m., Xi Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32793/
> -----------------------------------------------------------
>
> (Updated April 2, 2015, 10:40 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
>
>
> Bugs: AMBARI-10338
> https://issues.apache.org/jira/browse/AMBARI-10338
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Gauge: Threshold*
> Number: Threshold, Unit
> Graph: Graph Type*, Time Range*, Unit
> Template: Unit
>
> '*' field is require.
> Non-required field could be empty.
> Need validation for each property.
>
> Go to step3, the properties values entered in step2 is in {{controller.content.widgetProperties}}
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/widgets/create/step2_controller.js 2438a80
> ambari-web/app/models.js e9de30f
> ambari-web/app/models/widget.js 88a80e3
> ambari-web/app/models/widget_property.js PRE-CREATION
> ambari-web/app/styles/enhanced_service_dashboard.less 24e52a3
> ambari-web/app/templates/main/service/widgets/create/step2.hbs 50f7b86
> ambari-web/app/templates/main/service/widgets/create/widget_property_threshold.hbs PRE-CREATION
> ambari-web/app/views/main/service/widgets/create/step2_view.js 610e98c
>
> Diff: https://reviews.apache.org/r/32793/diff/
>
>
> Testing
> -------
>
> 5771 tests complete (10 seconds)
> 78 tests pending
>
>
> Thanks,
>
> Xi Wang
>
>