You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2022/08/03 02:38:47 UTC

[GitHub] [openwhisk-runtime-go] ningyougang commented on a diff in pull request #172: Upgrade gradle version

ningyougang commented on code in PR #172:
URL: https://github.com/apache/openwhisk-runtime-go/pull/172#discussion_r936183960


##########
golang1.17/Dockerfile:
##########
@@ -38,7 +38,7 @@ RUN echo "deb http://deb.debian.org/debian buster-backports main contrib non-fre
      librdkafka-dev=0.11.6-1.1 &&\
     # Cleanup apt data, we do not need them later on.
     apt-get clean && rm -rf /var/lib/apt/lists/* &&\
-    go get -u github.com/go-delve/delve/cmd/dlv@v1.8.1 &&\
+    go install github.com/go-delve/delve/cmd/dlv@v1.8.1 &&\

Review Comment:
   Fix issue
   ```
   go get: installing executables with 'go get' in module mode is deprecated.
   	Use 'go install pkg@version' instead.
   	For more information, see https://golang.org/doc/go-get-install-deprecation
   	or run 'go help get' or 'go help install'.
   # github.com/rivo/uniseg
   pkg/mod/github.com/rivo/uniseg@v0.3.1/properties.go:130:6: missing function body
   pkg/mod/github.com/rivo/uniseg@v0.3.1/properties.go:130:20: syntax error: unexpected [, expecting (
   note: module requires Go 1.18
   ```
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org