[GitHub] [superset] betodealmeida commented on a change in pull request #18093: feat: allow assets to be managed externally

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #18093:
URL: https://github.com/apache/superset/pull/18093#discussion_r788168201



##########
File path: superset/connectors/base/models.py
##########
@@ -110,6 +110,8 @@ def name(self) -> str:
     params = Column(String(1000))
     perm = Column(String(1000))
     schema_perm = Column(String(1000))
+    is_managed_externally = Column(Boolean, default=False)
+    external_url = Column(Text, nullable=True)

Review comment:
       The problem is that `external_url` should really be optional — depending on the source a resource might be managed externally, without having an external URL associated with it. So it might be possible to have `is_managed_externally=true` while at the same time `external_url=null`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org