You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by benbenw <gi...@git.apache.org> on 2016/03/04 09:32:09 UTC
[GitHub] jmeter pull request: Bug 52073 Embedded Resources concurrent downl...
GitHub user benbenw opened a pull request:
https://github.com/apache/jmeter/pull/155
Bug 52073 Embedded Resources concurrent download : Improve performances by avoiding shutdown of ThreadPoolExecutor at each sample.
A shared thread pool is used for all the parallel downloads.
A throttle mechanism is used per user to ensure the max concurrent
downloads setting is not exceeded.
A new parameter httpsampler.parallel_download_thread_keepalive_inseconds
is used to set the thread TTL when idle (default 60s).
the parameter httpsampler.await_termination_timeout is not used anymore
and has been removed.
TODO : ResourcesDownloader#shrink should be called at the end of a test
to accelerate the release of the thread pool idle threads (not
mandatory)
the httpclient is shared between the threads of a given virtual user.
the cache is shared between the threads of a given virtual user.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benbenw/jmeter resdownload3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/155.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #155
----
commit e5ac1cf4dcfb578444766300e9bc5005168acc46
Author: benoit <b....@ubik-ingenierie.com>
Date: 2016-02-17T22:46:36Z
Bug 52073 Embedded Resources concurrent download : Improve performances
by avoiding shutdown of ThreadPoolExecutor at each sample.
A shared thread pool is used for all the parallel downloads.
A throttle mechanism is used per user to ensure the max concurrent
downloads setting is not exceeded.
A new parameter httpsampler.parallel_download_thread_keepalive_inseconds
is used to set the thread TTL when idle (default 60s).
the parameter httpsampler.await_termination_timeout is not used anymore
and has been removed.
TODO : ResourcesDownloader#shrink should be called at the end of a test
to accelerate the release of the thread pool idle threads (not
mandatory)
the httpclient is shared between the threads of a given virtual user.
the cache is shared between the threads of a given virtual user.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Bug 52073 Embedded Resources concurrent downl...
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the pull request:
https://github.com/apache/jmeter/pull/155#issuecomment-194273164
Fixed within:
http://svn.apache.org/viewvc?rev=1734228&view=rev
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Bug 52073 Embedded Resources concurrent downl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/155
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---