You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/07/30 14:34:56 UTC

[GitHub] [camel] vindiagram-ng opened a new pull request #4058: Camel 15349

vindiagram-ng opened a new pull request #4058:
URL: https://github.com/apache/camel/pull/4058


   Updated the XmppConsumer to "chatWith" the Participant instead of the ChatId. This solves an error when configuring a route to consume from a participant with a domain id and without a room defined the call to 'JidCreate.entityBareFrom(endpoint.getChatId())' would throw and exception because of the ill-formed JID returned by getChatId.
   
   Added a function to XmppEndpoint to resolved the Fully qualified JID of the configured participant. This function when used by the XmppConsumer for direct chats will allow route participants to be defined without their domain and assume the domain of the server being connected too. This solves an error when configuring a route to consume from a participant without a domain id and without a room defined the call to 'JidCreate.entityBareFrom(endpoint.getChatId())' would throw and exception because of the ill-formed JID returned by getChatId.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] oscerd commented on pull request #4058: Camel 15349

Posted by GitBox <gi...@apache.org>.

oscerd commented on pull request #4058:
URL: https://github.com/apache/camel/pull/4058#issuecomment-666930325


   Sadly the gh action for backporting doesn't work anymore. Need to dig a bit. Let me do this manually.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] oscerd merged pull request #4058: Camel 15349

Posted by GitBox <gi...@apache.org>.

oscerd merged pull request #4058:
URL: https://github.com/apache/camel/pull/4058


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] oscerd commented on pull request #4058: Camel 15349

Posted by GitBox <gi...@apache.org>.

oscerd commented on pull request #4058:
URL: https://github.com/apache/camel/pull/4058#issuecomment-666934212


   Thanks for the PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus commented on pull request #4058: Camel 15349

Posted by GitBox <gi...@apache.org>.

davsclaus commented on pull request #4058:
URL: https://github.com/apache/camel/pull/4058#issuecomment-666428249


   Thanks for the PR. As @oscerd says then the code formatting need a little which you can run with
   
       mvn compile -P sourcecheck
   
   in the camel-xmpp folder. Then fix those errors reported and push to this PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org