You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Dan Tran (JIRA)" <ji...@codehaus.org> on 2007/07/11 08:08:13 UTC

[jira] Created: (MECLIPSE-296) Wrong generated source-path when warSourceDirectory is changed

Wrong generated source-path when warSourceDirectory is changed
--------------------------------------------------------------

                 Key: MECLIPSE-296
                 URL: http://jira.codehaus.org/browse/MECLIPSE-296
             Project: Maven 2.x Eclipse Plugin
          Issue Type: Bug
          Components: WTP support
    Affects Versions: 2.4
         Environment: xp
            Reporter: Dan Tran


When warSourceDirectory of the war configuration is explicitly set relative to project basedir, its source-path is incorrectly set in reactor mode.
The path is constructed using the reactor's basedir + warSourceDirectory. It must be project's basedir + warSourceDirectory

The work around is to set   warSourceDirectory using absolute path

here is the configuration to reproduce the issue

      <plugin>
        <artifactId>maven-war-plugin</artifactId>
        <configuration>
          <warSourceDirectory>webapp</warSourceDirectory>
        </configuration>
      </plugin>

the incorrected source-path is in ..settings\org.eclipse.wst.common.component

The work around is 

      <plugin>
        <artifactId>maven-war-plugin</artifactId>
        <configuration>
          <warSourceDirectory>${basedir}/webapp</warSourceDirectory>
        </configuration>
      </plugin>

The main problem in code is in IdeUtils.getCanonicalPath() returns incorrect path in reactor mode.




-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MECLIPSE-296) Wrong generated source-path when warSourceDirectory is set

Posted by "Dan Tran (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MECLIPSE-296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Tran updated MECLIPSE-296:
------------------------------

    Fix Version/s: 2.5
          Summary: Wrong generated source-path when warSourceDirectory is set  (was: Wrong generated source-path when warSourceDirectory is changed)

> Wrong generated source-path when warSourceDirectory is set
> ----------------------------------------------------------
>
>                 Key: MECLIPSE-296
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-296
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: WTP support
>    Affects Versions: 2.4
>         Environment: xp
>            Reporter: Dan Tran
>             Fix For: 2.5
>
>
> When warSourceDirectory of the war configuration is explicitly set relative to project basedir, its source-path is incorrectly set in reactor mode.
> The path is constructed using the reactor's basedir + warSourceDirectory. It must be project's basedir + warSourceDirectory
> The work around is to set   warSourceDirectory using absolute path
> here is the configuration to reproduce the issue
>       <plugin>
>         <artifactId>maven-war-plugin</artifactId>
>         <configuration>
>           <warSourceDirectory>webapp</warSourceDirectory>
>         </configuration>
>       </plugin>
> the incorrected source-path is in ..settings\org.eclipse.wst.common.component
> The work around is 
>       <plugin>
>         <artifactId>maven-war-plugin</artifactId>
>         <configuration>
>           <warSourceDirectory>${basedir}/webapp</warSourceDirectory>
>         </configuration>
>       </plugin>
> The main problem in code is in IdeUtils.getCanonicalPath() returns incorrect path in reactor mode.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MECLIPSE-296) Wrong generated source-path when warSourceDirectory is set

Posted by "Dan Tran (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MECLIPSE-296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Tran closed MECLIPSE-296.
-----------------------------

      Assignee: Dan Tran
    Resolution: Fixed

committed the fix togetter with  MECLIPSE-127 where IdeUtils.toRelativeAndFixSeparator must convert 'fileToAdd' to absolute path
base on project directory

> Wrong generated source-path when warSourceDirectory is set
> ----------------------------------------------------------
>
>                 Key: MECLIPSE-296
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-296
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: WTP support
>    Affects Versions: 2.4
>         Environment: xp
>            Reporter: Dan Tran
>            Assignee: Dan Tran
>             Fix For: 2.5
>
>
> When warSourceDirectory of the war configuration is explicitly set relative to project basedir, its source-path is incorrectly set in reactor mode.
> The path is constructed using the reactor's basedir + warSourceDirectory. It must be project's basedir + warSourceDirectory
> The work around is to set   warSourceDirectory using absolute path
> here is the configuration to reproduce the issue
>       <plugin>
>         <artifactId>maven-war-plugin</artifactId>
>         <configuration>
>           <warSourceDirectory>webapp</warSourceDirectory>
>         </configuration>
>       </plugin>
> the incorrected source-path is in ..settings\org.eclipse.wst.common.component
> The work around is 
>       <plugin>
>         <artifactId>maven-war-plugin</artifactId>
>         <configuration>
>           <warSourceDirectory>${basedir}/webapp</warSourceDirectory>
>         </configuration>
>       </plugin>
> The main problem in code is in IdeUtils.getCanonicalPath() returns incorrect path in reactor mode.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira