[GitHub] [airflow] rishkarajgi commented on a diff in pull request #24668: added component specific labels

[GitBox <gi...@apache.org>]

rishkarajgi commented on code in PR #24668:
URL: https://github.com/apache/airflow/pull/24668#discussion_r918799436


##########
chart/templates/cleanup/cleanup-cronjob.yaml:
##########
@@ -38,9 +38,9 @@ metadata:
     chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
     release: {{ .Release.Name }}
     heritage: {{ .Release.Service }}
-{{- with .Values.labels }}
-{{ toYaml . | indent 4 }}
-{{- end }}
+  {{- if or (.Values.labels) (.Values.cleanup.labels) }}
+  {{- mustMerge .Values.cleanup.labels .Values.labels | toYaml | nindent 4 }}
+  {{- end }}

Review Comment:
   @jedcunningham I tested this by adding labels to both global labels and to container specific labels. It is showing both in the helm template.
   An alternative to merge would be using two if conditions 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org