You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by "prabhjyotsingh (via GitHub)" <gi...@apache.org> on 2025/11/14 19:31:35 UTC

[PR] AMBARI-26556: Add a way to encrypted configurations.json file in the ambari-agent's cache [ambari]

prabhjyotsingh opened a new pull request, #4087:
URL: https://github.com/apache/ambari/pull/4087

   ## What changes were proposed in this pull request?
   
   Add a way to encrypted configurations.json file in the ambari-agent's cache
   
   ## How was this patch tested?
   
   before enabling encryption:
   ``` cluster_cache]# cat configurations.json 
   {
     "2": {
       "configurations": {
         "admin-logback": {
           "content": "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<!--\n  Licensed to the Apache Software Foundation (ASF) under one or more\n  contributor license agreements.  See the NOTICE file distributed with\n  this work for additional information regarding copyright ownership.\n  The ASF licenses this file to You under the Apache License, Version 2.0\n  (the \"License\"); 
   ```
   
   after enabling encryption:
   ```
   cluster_cache]# cat configurations.json 
   gAAAAABpF4NSJSaCrgJNafiqILdEnlnKFnRddzJyOCsSXR8HMGJmMJJeiVL9cT93QG5CT8uMJuWf2VDKEb9YaFXFqL73Sn4Aj0KhI7zUPOCtTyjBTgckswr3Eqcd8OLVMG1Q5n4GunyMnSv9AOaIH1RfAg7jfyBb8vms4NNicAvu7NM5flyYwJmp1yfX2dV3Y7j-5X6y08gnxoWVD0WaOkMXp4BC6pNzcBHyD5crihn1lELjgCOyjT_EtVHd2w482MB8IQkGWRXpjaIaU6O_Ozld0eznlCbdJcfYLQ2mnv6CbYsSHh0mn8iSw3Q5iYAbW4eCN6toiRXeFbBAYZ2hKyay3Pfq7L0ZC3CtNOVphU378gtSYCOXL8O07xBmykVk-jgwsGIQUah2AXJTDuK_qGlTGhGeqn-czl66OgYp7ceaHj7mOndtpgXeC9CtRQfjTzqUKnC8jY90Kf7sZFQsp3pavzy-aEJ_dboM83Q6_ObZqY8ORrjZA3zC6uYUzHhyPMXKO__p_9YUMFvcKhKVnIzmCGEElTVr7mvtMTmMU4TUHa_QxiQnfKwFUGqE390vJL-qbPV_0iqmBka7Dya5s7OVZkIRPHUngXCaCyF9iMIjl5gQn03eX2T4Z4-sfPXAYxjP7udiCgyK8aFDF-m-KzhC5EEASLk7J1ZqWLEGwMCoC3FgTExIfHXIoVUltQ76cYlqsIqHHEteUpi0Cqh7dLA0KOGwNPwNKrgzNzqmm2YImdQbM4FlGoR3sUsaGwbCg-fEjZIxgXHd4DbaN6CTCcAaa_VuKmBc_cQRKi_eaj4OmTyQnsNmUcFarBhTV55L1KE8kg5Xrp3UJYgm0ThlH0rweOmvskPEFWNimx_jhVWmoJID4mC1E97K41rHXBpAbfuPYndE3S2d4DAfXiw6ZmUMVClnK8-
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org

Re: [PR] AMBARI-26556: Add a way to encrypted configurations.json file in the ambari-agent's cache [ambari]

Posted by "prabhjyotsingh (via GitHub)" <gi...@apache.org>.
prabhjyotsingh commented on code in PR #4087:
URL: https://github.com/apache/ambari/pull/4087#discussion_r2529498930


##########
ambari-agent/conf/unix/ambari-agent.ini:
##########
@@ -57,6 +57,11 @@ ssl_verify_cert=0
 credential_lib_dir=/var/lib/ambari-agent/cred/lib
 credential_conf_dir=/var/lib/ambari-agent/cred/conf
 credential_shell_cmd=org.apache.hadoop.security.alias.CredentialShell
+; Both agent_secret and agent_salt are required if the user wants to enable encryption, and they

Review Comment:
   Will I need to add documentation somewhere else as well? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org

Re: [PR] AMBARI-26556: Add a way to encrypted configurations.json file in the ambari-agent's cache [ambari]

Posted by "prabhjyotsingh (via GitHub)" <gi...@apache.org>.
prabhjyotsingh commented on PR #4087:
URL: https://github.com/apache/ambari/pull/4087#issuecomment-3915943227

   @sandeepk318  let me know if there are any changes required in this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org

Re: [PR] AMBARI-26556: Add a way to encrypted configurations.json file in the ambari-agent's cache [ambari]

Posted by "prabhjyotsingh (via GitHub)" <gi...@apache.org>.
prabhjyotsingh commented on PR #4087:
URL: https://github.com/apache/ambari/pull/4087#issuecomment-3617813815

   @JiaLiangC can you help me review this PR?
   
   After spending more time on this, I realized there’s an internal implementation of ambari_pbkdf2, so I decided to use that instead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org

Re: [PR] AMBARI-26556: Add a way to encrypted configurations.json file in the ambari-agent's cache [ambari]

Posted by "prabhjyotsingh (via GitHub)" <gi...@apache.org>.
prabhjyotsingh commented on PR #4087:
URL: https://github.com/apache/ambari/pull/4087#issuecomment-3541669223

   @JiaLiangC sure I've added a few.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org

Re: [PR] AMBARI-26556: Add a way to encrypted configurations.json file in the ambari-agent's cache [ambari]

Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC commented on PR #4087:
URL: https://github.com/apache/ambari/pull/4087#issuecomment-3535307060

   @prabhjyotsingh  plz add  some unit test for your change


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org

Re: [PR] AMBARI-26556: Add a way to encrypted configurations.json file in the ambari-agent's cache [ambari]

Posted by "sandeep318kumar (via GitHub)" <gi...@apache.org>.
sandeep318kumar commented on PR #4087:
URL: https://github.com/apache/ambari/pull/4087#issuecomment-3861211393

   @prabhjyotsingh also can you squash your 10 commits into single one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org

Re: [PR] AMBARI-26556: Add a way to encrypted configurations.json file in the ambari-agent's cache [ambari]

Posted by "prabhjyotsingh (via GitHub)" <gi...@apache.org>.
prabhjyotsingh commented on code in PR #4087:
URL: https://github.com/apache/ambari/pull/4087#discussion_r2529493433


##########
setup.py:
##########
@@ -131,7 +131,7 @@ def get_version():
   + get_ambari_server_stack_package()
   + get_extra_common_packages(),
   package_dir=create_package_dir_map(),
-  install_requires=["coilmq==1.0.1"],
+  install_requires=["coilmq==1.0.1", "cryptography==46.0.3"],

Review Comment:
   I’m uncertain whether this change is necessary. If it isn’t, I can revert it, or we can relocate it to a more suitable location if needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org

Re: [PR] AMBARI-26556: Add a way to encrypted configurations.json file in the ambari-agent's cache [ambari]

Posted by "prabhjyotsingh (via GitHub)" <gi...@apache.org>.
prabhjyotsingh commented on PR #4087:
URL: https://github.com/apache/ambari/pull/4087#issuecomment-3864495914

   @sandeep318kumar sure I just did.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org

Re: [PR] AMBARI-26556: Add a way to encrypted configurations.json file in the ambari-agent's cache [ambari]

Posted by "prabhjyotsingh (via GitHub)" <gi...@apache.org>.
prabhjyotsingh commented on PR #4087:
URL: https://github.com/apache/ambari/pull/4087#issuecomment-3562964285

   @JiaLiangC  can you help me review this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org