[jira] [Commented] (GEODE-5101) Cmake Find Module for Geode Native Not Correct

["Blake Bender (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-5101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464285#comment-16464285 ] 

Blake Bender commented on GEODE-5101:
-------------------------------------

Investigated this morning, here are my findings:
 * FindGeodeNative.cmake in the _source_ tree is _not_ hardcoded.  When you build the 'install' target, cmake processes FindGeodeNative.cmake.in and produces a FindGeodeNative.cmake with a hardcoded path.  This is by design.
 * On the other hand, the hardcoded path produced is incorrect for the directory our 'install' cmake target produces.  These are as follows:
 ** On Mac, and presumably other *nix flavors, the directory 'geode-native-install' is created at the peer level to the geode-native source tree
 ** On Windows, the 'nativeclient' directory is created under 'c:\Program Files'.  I haven't investigated what happens if you've set up Windows on a different drive, so there is no 'c:\Program Files', but I believe that to be beyond the scope of this ticket.
 * On the _other_ other hand, an incorrect hardcoded path doesn't appear to make any difference, because the next path the cmake module looks in is relative to the current cmake directory, which should always work unless the user has manually moved the examples directory outside the tree.  Again, this is beyond the scope of our ticket and IMO should be explicitly unsupported. 
 * I verified building examples works on both Mac and Windows, both in the case where you create a build directory in the examples tree _and_ when creating a build directory outside the tree.

Based on the results above, I'm going to close this ticket as 'not a bug', no fix is necessary.

 

> Cmake Find Module for Geode Native Not Correct
> ----------------------------------------------
>
>                 Key: GEODE-5101
>                 URL: https://issues.apache.org/jira/browse/GEODE-5101
>             Project: Geode
>          Issue Type: Bug
>          Components: native client
>            Reporter: Michael Martell
>            Priority: Major
>
> FindGeodeNative.cmake is hardcoded to look for the geode-native install in an apache-geode subdirectory. This should not be hardcoded, but should look in the install folder.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)