[jira] [Commented] (PIG-4613) Fix unit test failures about TestAssert

["kexianda (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14605229#comment-14605229 ] 

kexianda commented on PIG-4613:
-------------------------------

The test cases failed because the exception is different between spark and mapreduce engine.

Spark Engine:
org.apache.pig.builtin.Assert will throw an exception as expected, and spark scheduler catch it and re-throw out. Then SparkLauncher and PigServer catch it and throw it out.  *Client user can get the error message from org.apache.pig.builtin.Assert*

MapReduce engine:
org.apache.pig.builtin.Assert will throw an exception as expected. But LocalJobRunner(local mode) will not notify the JobController of that exception. So, MapReduceLauncher and PigServer *can not* get the exception thrown from org.apache.pig.builtin.Assert. PigServer just throw *an exception with default error message.*

>From my understanding, the behavior of spark engine is reasonable.  So I just change the testcase to pass UT in spark mode.
 
[~mohitsabharwal] & [~kellyzly] Any comments?  Thanks.

Regards,
Xianda

> Fix unit test failures about TestAssert
> ---------------------------------------
>
>                 Key: PIG-4613
>                 URL: https://issues.apache.org/jira/browse/PIG-4613
>             Project: Pig
>          Issue Type: Sub-task
>          Components: spark
>            Reporter: kexianda
>            Assignee: kexianda
>             Fix For: spark-branch
>
>         Attachments: PIG-4613.patch
>
>
> UT failed at following cases:
> org.apache.pig.test.TestAssert.testNegativeWithoutFetch
> org.apache.pig.test.TestAssert.testNegative



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)