You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2019/07/20 00:27:40 UTC
[GitHub] [samza] shenodaguirguis commented on issue #1106: Making
Samza-Sql-Shell commands pluggable
shenodaguirguis commented on issue #1106: Making Samza-Sql-Shell commands pluggable
URL: https://github.com/apache/samza/pull/1106#issuecomment-513418263
my 2-mites:
+ the load/unload commands makes perfect sense, can be a future work
+ I am not a big fan of prefixing commands with handlers, not very user friendly? ... besides, with load/unload this won't be needed, but I don't anticipate users shuffling command handlers much, this feature is mainly to allow each user to plug-in their favorite handler.
+ We can discuss offline the env vars scope, I don't see them applicable per handler...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services