You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by ma...@apache.org on 2017/10/16 06:20:32 UTC

[trafficserver] branch quic-latest updated: Change handshake state after handshake has completely completed

This is an automated email from the ASF dual-hosted git repository.

maskit pushed a commit to branch quic-latest
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/quic-latest by this push:
     new 03b95cd  Change handshake state after handshake has completely completed
03b95cd is described below

commit 03b95cdd897a245fc1544a60bc30e6b50ddf03e6
Author: Masakazu Kitajo <ma...@apache.org>
AuthorDate: Mon Oct 16 15:19:26 2017 +0900

    Change handshake state after handshake has completely completed
---
 iocore/net/quic/QUICHandshake.cc | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/iocore/net/quic/QUICHandshake.cc b/iocore/net/quic/QUICHandshake.cc
index aa5930c..d78b909 100644
--- a/iocore/net/quic/QUICHandshake.cc
+++ b/iocore/net/quic/QUICHandshake.cc
@@ -132,7 +132,7 @@ QUICHandshake::is_version_negotiated()
 bool
 QUICHandshake::is_completed()
 {
-  return this->_crypto->is_handshake_finished();
+  return this->handler == &QUICHandshake::state_complete;
 }
 
 QUICVersion
@@ -380,17 +380,18 @@ QUICHandshake::_process_client_finished()
     I_WANNA_DUMP_THIS_BUF(out, static_cast<int64_t>(out_len));
     // <----- DEBUG -----
 
-    ink_assert(this->is_completed());
+    ink_assert(this->_crypto->is_handshake_finished());
     DebugQHS("Handshake is completed");
 
-    DebugQHS("Enter state_complete");
-    SET_HANDLER(&QUICHandshake::state_complete);
     _process_handshake_complete();
 
     stream_io->write(out, out_len);
     stream_io->write_reenable();
     stream_io->read_reenable();
 
+    DebugQHS("Enter state_complete");
+    SET_HANDLER(&QUICHandshake::state_complete);
+
     return QUICErrorUPtr(new QUICNoError());
   } else {
     return QUICErrorUPtr(new QUICConnectionError(QUICErrorClass::CRYPTOGRAPHIC, QUICErrorCode::TLS_HANDSHAKE_FAILED));

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>'].