[GitHub] [beam] lukecwik commented on a change in pull request #11325: [BEAM-4374, BEAM-6189] Delete and remove deprecated Metrics proto

[GitBox <gi...@apache.org>]

lukecwik commented on a change in pull request #11325: [BEAM-4374, BEAM-6189] Delete and remove deprecated Metrics proto
URL: https://github.com/apache/beam/pull/11325#discussion_r404388516
 
 

 ##########
 File path: model/fn-execution/src/main/proto/beam_fn_api.proto
 ##########
 @@ -253,18 +253,13 @@ message ProcessBundleRequest {
 }
 
 message ProcessBundleResponse {
-  // (Optional) If metrics reporting is supported by the SDK, this represents
-  // the final metrics to record for this bundle.
-  // DEPRECATED
-  Metrics metrics = 1;
-
   // (Optional) Specifies that the bundle has not been completed and the
   // following applications need to be scheduled and executed in the future.
   // A runner that does not yet support residual roots MUST still check that
   // this is empty for correctness.
   repeated DelayedBundleApplication residual_roots = 2;
 
-  // (Required) The list of metrics or other MonitoredState
+  // DEPRECATED (Required) The list of metrics or other MonitoredState
   // collected while processing this bundle.
   repeated org.apache.beam.model.pipeline.v1.MonitoringInfo monitoring_infos = 3;
 
 Review comment:
   The plan is to go with short ids system as the one and only implementation and may not have enough time to remove these two fields before the 2.21 release.
   
   I want to have the option to un-deprecate them or remove them after the release.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services