You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Antonio Andrade (JIRA)" <ji...@apache.org> on 2008/10/16 21:21:44 UTC

[jira] Issue Comment Edited: (AXIS2-4090) WSDL11ToAxisServiceBuilder: Population of AxisBindingMessage and AxisMessages objects is inconsistent when the isServerSide flag is set to false

    [ https://issues.apache.org/jira/browse/AXIS2-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640216#action_12640216 ] 

aandrade edited comment on AXIS2-4090 at 10/16/08 12:21 PM:
-------------------------------------------------------------------

Submitting patch for Review: 

Setting the value of both the operation MEP and message labels depending of the 'isServerSide' flag value.

Other: I think that the 'isServerSide' flag usage should be reviewed and a general refactoring should be considered. i.e. There should probably be methods defined in the WSDLToAxisServiceBuilder that deal with the retrieval of isServerSide-sensitive information (messages based on directions, labels, etc) in a more consistent way. The usage of  this flag has caused a lot of duplication of code


      was (Author: aandrade):
    Setting the value of both the operation MEP and message labels depending of the 'isServerSide' flag value.

Other: I think that the 'isServerSide' flag usage should be reviewed and a general refactoring should be considered. i.e. There should probably be methods defined in the WSDLToAxisServiceBuilder that deal with the retrieval of isServerSide-sensitive information (messages based on directions, labels, etc) in a more consistent way. The usage of  this flag has caused a lot of duplication of code

  
> WSDL11ToAxisServiceBuilder: Population of AxisBindingMessage and AxisMessages objects is inconsistent when the isServerSide flag is set to false
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: AXIS2-4090
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4090
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.4, nightly
>         Environment: Windows XP. 4GB RAM Intel Xeon dual-core @2.83Ghz
>            Reporter: Antonio Andrade
>         Attachments: AXIS2-4090.patch
>
>   Original Estimate: 6h
>  Remaining Estimate: 6h
>
> Observed Behavior: 
> Within the 'populateBinding' method, both the Message Exchange Pattern of the operation -axisOperation.getMessageExchangePattern()- and the message labels -WSDLConstants.MESSAGE_LABEL_XX_VALUE- depend on the 'isServerSide' flag but this dependency is ignored when the AxisBindingMessage and AxisMessage objects are being populated. This can be seen whenever the 'isServerSide' flag is set to 'false'.
> Expected Behavior: 
> The value of both the operation's MEP and message labels should be retrieved taking into consideration the 'isServerSide' flag.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org