[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #208: Add pekko-http-cors module

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on code in PR #208:
URL: https://github.com/apache/incubator-pekko-http/pull/208#discussion_r1248696319


##########
http-cors/src/main/scala/org/apache/pekko/http/cors/javadsl/settings/CorsSettings.scala:
##########
@@ -0,0 +1,59 @@
+package org.apache.pekko.http.cors.javadsl.settings

Review Comment:
   I just updated the PR, I ended up using
   
   ```
   /*
    * Licensed to the Apache Software Foundation (ASF) under one or more
    * license agreements; and to You under the Apache License, version 2.0:
    *
    *   https://www.apache.org/licenses/LICENSE-2.0
    */
    ```
    
    which is the same as the standard header but without the "derived from Akka" part



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org