You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/05/11 04:19:57 UTC
[GitHub] [hudi] BruceKellan opened a new pull request, #5555: [MINOR] Fixing streaming read a hoodie table with complex data type w…
BruceKellan opened a new pull request, #5555:
URL: https://github.com/apache/hudi/pull/5555
…hen using flink-1.13
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5555: [MINOR] Fixing streaming read a hoodie table with complex data type w…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5555:
URL: https://github.com/apache/hudi/pull/5555#issuecomment-1142000165
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eb4ce6f1d34aeb96db1b2935f9079b98a41a4237",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8567",
"triggerID" : "eb4ce6f1d34aeb96db1b2935f9079b98a41a4237",
"triggerType" : "PUSH"
}, {
"hash" : "9a95d9c1f1561c024cdad6782053387a1176d5b0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9016",
"triggerID" : "9a95d9c1f1561c024cdad6782053387a1176d5b0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eb4ce6f1d34aeb96db1b2935f9079b98a41a4237 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8567)
* 9a95d9c1f1561c024cdad6782053387a1176d5b0 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9016)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5555: [HUDI-4172] Fix the compatibility of flink1.13 when using complex data type.
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5555:
URL: https://github.com/apache/hudi/pull/5555#issuecomment-1143158373
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eb4ce6f1d34aeb96db1b2935f9079b98a41a4237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8567",
"triggerID" : "eb4ce6f1d34aeb96db1b2935f9079b98a41a4237",
"triggerType" : "PUSH"
}, {
"hash" : "9a95d9c1f1561c024cdad6782053387a1176d5b0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9016",
"triggerID" : "9a95d9c1f1561c024cdad6782053387a1176d5b0",
"triggerType" : "PUSH"
}, {
"hash" : "d7a641dc8904cd778fe6b175081d6289a509ef8a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9022",
"triggerID" : "d7a641dc8904cd778fe6b175081d6289a509ef8a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d7a641dc8904cd778fe6b175081d6289a509ef8a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9022)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5555: [HUDI-4172] Fix the compatibility of flink1.13 when using complex data type.
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5555:
URL: https://github.com/apache/hudi/pull/5555#issuecomment-1143100963
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eb4ce6f1d34aeb96db1b2935f9079b98a41a4237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8567",
"triggerID" : "eb4ce6f1d34aeb96db1b2935f9079b98a41a4237",
"triggerType" : "PUSH"
}, {
"hash" : "9a95d9c1f1561c024cdad6782053387a1176d5b0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9016",
"triggerID" : "9a95d9c1f1561c024cdad6782053387a1176d5b0",
"triggerType" : "PUSH"
}, {
"hash" : "d7a641dc8904cd778fe6b175081d6289a509ef8a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9022",
"triggerID" : "d7a641dc8904cd778fe6b175081d6289a509ef8a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9a95d9c1f1561c024cdad6782053387a1176d5b0 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9016)
* d7a641dc8904cd778fe6b175081d6289a509ef8a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9022)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #5555: [MINOR] Fixing streaming read a hoodie table with complex data type w…
Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #5555:
URL: https://github.com/apache/hudi/pull/5555#discussion_r869984811
##########
packaging/hudi-flink-bundle/pom.xml:
##########
@@ -221,6 +221,33 @@
<pattern>com.fasterxml.jackson.</pattern>
<shadedPattern>${flink.bundle.shade.prefix}com.fasterxml.jackson.</shadedPattern>
</relocation>
+ <!-- The classes below in org.apache.flink.table.data package come from flink-table-runtime,
+ which have to be shaded one by one,
+ instead of shading all classes under org.apache.flink.table.data. -->
+ <relocation>
+ <pattern>org.apache.flink.table.data.ColumnarRowData</pattern>
+ <shadedPattern>${flink.bundle.shade.prefix}org.apache.flink.table.data.ColumnarRowData</shadedPattern>
Review Comment:
Oops, the fix is ugly, we may need to find better solution ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] BruceKellan closed pull request #5555: [HUDI-4172] Fix the compatibility of flink1.13 when using complex data type.
Posted by GitBox <gi...@apache.org>.
BruceKellan closed pull request #5555: [HUDI-4172] Fix the compatibility of flink1.13 when using complex data type.
URL: https://github.com/apache/hudi/pull/5555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5555: [MINOR] Fixing streaming read a hoodie table with complex data type w…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5555:
URL: https://github.com/apache/hudi/pull/5555#issuecomment-1123185154
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eb4ce6f1d34aeb96db1b2935f9079b98a41a4237",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "eb4ce6f1d34aeb96db1b2935f9079b98a41a4237",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eb4ce6f1d34aeb96db1b2935f9079b98a41a4237 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5555: [HUDI-4172] Fix the compatibility of flink1.13 when using complex data type.
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5555:
URL: https://github.com/apache/hudi/pull/5555#issuecomment-1143099200
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eb4ce6f1d34aeb96db1b2935f9079b98a41a4237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8567",
"triggerID" : "eb4ce6f1d34aeb96db1b2935f9079b98a41a4237",
"triggerType" : "PUSH"
}, {
"hash" : "9a95d9c1f1561c024cdad6782053387a1176d5b0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9016",
"triggerID" : "9a95d9c1f1561c024cdad6782053387a1176d5b0",
"triggerType" : "PUSH"
}, {
"hash" : "d7a641dc8904cd778fe6b175081d6289a509ef8a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d7a641dc8904cd778fe6b175081d6289a509ef8a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9a95d9c1f1561c024cdad6782053387a1176d5b0 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9016)
* d7a641dc8904cd778fe6b175081d6289a509ef8a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5555: [MINOR] Fixing streaming read a hoodie table with complex data type w…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5555:
URL: https://github.com/apache/hudi/pull/5555#issuecomment-1123186615
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eb4ce6f1d34aeb96db1b2935f9079b98a41a4237",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8567",
"triggerID" : "eb4ce6f1d34aeb96db1b2935f9079b98a41a4237",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eb4ce6f1d34aeb96db1b2935f9079b98a41a4237 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8567)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5555: [MINOR] Fixing streaming read a hoodie table with complex data type w…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5555:
URL: https://github.com/apache/hudi/pull/5555#issuecomment-1123306986
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eb4ce6f1d34aeb96db1b2935f9079b98a41a4237",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8567",
"triggerID" : "eb4ce6f1d34aeb96db1b2935f9079b98a41a4237",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eb4ce6f1d34aeb96db1b2935f9079b98a41a4237 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8567)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] BruceKellan commented on a diff in pull request #5555: [MINOR] Fixing streaming read a hoodie table with complex data type w…
Posted by GitBox <gi...@apache.org>.
BruceKellan commented on code in PR #5555:
URL: https://github.com/apache/hudi/pull/5555#discussion_r870119683
##########
packaging/hudi-flink-bundle/pom.xml:
##########
@@ -221,6 +221,33 @@
<pattern>com.fasterxml.jackson.</pattern>
<shadedPattern>${flink.bundle.shade.prefix}com.fasterxml.jackson.</shadedPattern>
</relocation>
+ <!-- The classes below in org.apache.flink.table.data package come from flink-table-runtime,
+ which have to be shaded one by one,
+ instead of shading all classes under org.apache.flink.table.data. -->
+ <relocation>
+ <pattern>org.apache.flink.table.data.ColumnarRowData</pattern>
+ <shadedPattern>${flink.bundle.shade.prefix}org.apache.flink.table.data.ColumnarRowData</shadedPattern>
Review Comment:
Okey, I will find a better way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5555: [MINOR] Fixing streaming read a hoodie table with complex data type w…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5555:
URL: https://github.com/apache/hudi/pull/5555#issuecomment-1142073303
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eb4ce6f1d34aeb96db1b2935f9079b98a41a4237",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8567",
"triggerID" : "eb4ce6f1d34aeb96db1b2935f9079b98a41a4237",
"triggerType" : "PUSH"
}, {
"hash" : "9a95d9c1f1561c024cdad6782053387a1176d5b0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9016",
"triggerID" : "9a95d9c1f1561c024cdad6782053387a1176d5b0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9a95d9c1f1561c024cdad6782053387a1176d5b0 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9016)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org