You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/09/11 11:06:03 UTC
[PR] Alamb/remove string view warning [arrow-rs]
alamb opened a new pull request, #6380:
URL: https://github.com/apache/arrow-rs/pull/6380
# Which issue does this PR close?
Part of #6163
# Rationale for this change
As I was reviewing https://github.com/apache/arrow-rs/pull/6368 I came across a warning about Utf8View being not completely supported which was added in #5470 by @XiangpengHao when we began the implementation
Given these types are now supported across most of this crate I think this warning is no longer relevant
# What changes are included in this PR?
Remove warning in comments
# Are there any user-facing changes?
Doc changes, no functional changes
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove "NOT YET FULLY SUPPORTED" comment from DataType::Utf8View/BinaryView [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6380:
URL: https://github.com/apache/arrow-rs/pull/6380#issuecomment-2343663990
> Do you intend to leave in the warnings about ListView and LargeListView?
>
> https://github.com/apache/arrow-rs/blob/704f90bbf541896387bed030e12a39be308047e8/arrow-schema/src/datatype.rs#L297-L299
>
> https://github.com/apache/arrow-rs/blob/704f90bbf541896387bed030e12a39be308047e8/arrow-schema/src/datatype.rs#L312-L314
Unfortunately I think they are still largely unimplemented (tracked by https://github.com/apache/arrow-rs/issues/5375)
@Kikkon has some work here https://github.com/apache/arrow-rs/issues/5501 but needs help reviewing it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove "NOT YET FULLY SUPPORTED" comment from DataType::Utf8View/BinaryView [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6380:
URL: https://github.com/apache/arrow-rs/pull/6380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove "NOT YET FULLY SUPPORTED" comment from DataType::Utf8View/BinaryView [arrow-rs]
Posted by "kylebarron (via GitHub)" <gi...@apache.org>.
kylebarron commented on PR #6380:
URL: https://github.com/apache/arrow-rs/pull/6380#issuecomment-2343596424
Do you intend to leave in the warnings about ListView and LargeListView?
https://github.com/apache/arrow-rs/blob/704f90bbf541896387bed030e12a39be308047e8/arrow-schema/src/datatype.rs#L297-L299
https://github.com/apache/arrow-rs/blob/704f90bbf541896387bed030e12a39be308047e8/arrow-schema/src/datatype.rs#L312-L314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove "NOT YET FULLY SUPPORTED" comment from DataType::Utf8View/BinaryView [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6380:
URL: https://github.com/apache/arrow-rs/pull/6380#issuecomment-2356372439
Thanks for the reviews @Xuanwo and @kylebarron
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org