You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aries.apache.org by "John Ross (JIRA)" <ji...@apache.org> on 2011/07/11 20:54:59 UTC
[jira] [Created] (ARIES-708) org.apache.aries.util pom should point
to java6-parent, not java5-parent
org.apache.aries.util pom should point to java6-parent, not java5-parent
------------------------------------------------------------------------
Key: ARIES-708
URL: https://issues.apache.org/jira/browse/ARIES-708
Project: Aries
Issue Type: Bug
Components: Util
Affects Versions: 0.4
Reporter: John Ross
Assignee: John Ross
Pulled in org.apache.aries.util using m2e and received a bunch of errors about the @Override annotation use on implemented interface methods. Parent should be java6-parent.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ARIES-708) org.apache.aries.util pom should point
to java6-parent, not java5-parent
Posted by "Jeremy Hughes (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Hughes updated ARIES-708:
--------------------------------
Fix Version/s: (was: 0.4)
parent-0.5.0
> org.apache.aries.util pom should point to java6-parent, not java5-parent
> ------------------------------------------------------------------------
>
> Key: ARIES-708
> URL: https://issues.apache.org/jira/browse/ARIES-708
> Project: Aries
> Issue Type: Bug
> Components: Util
> Affects Versions: 0.4
> Reporter: John Ross
> Assignee: John Ross
> Fix For: parent-0.5.0
>
>
> Pulled in org.apache.aries.util using m2e and received a bunch of errors about the @Override annotation use on implemented interface methods. Parent should be java6-parent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (ARIES-708) org.apache.aries.util pom should
point to java6-parent, not java5-parent
Posted by "John Ross (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Ross resolved ARIES-708.
-----------------------------
Resolution: Fixed
Fix Version/s: 0.4
Committed changes.
> org.apache.aries.util pom should point to java6-parent, not java5-parent
> ------------------------------------------------------------------------
>
> Key: ARIES-708
> URL: https://issues.apache.org/jira/browse/ARIES-708
> Project: Aries
> Issue Type: Bug
> Components: Util
> Affects Versions: 0.4
> Reporter: John Ross
> Assignee: John Ross
> Fix For: 0.4
>
>
> Pulled in org.apache.aries.util using m2e and received a bunch of errors about the @Override annotation use on implemented interface methods. Parent should be java6-parent.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ARIES-708) org.apache.aries.util pom should
point to java6-parent, not java5-parent
Posted by "Valentin Mahrwald (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063958#comment-13063958 ]
Valentin Mahrwald commented on ARIES-708:
-----------------------------------------
Sounds very good. Thank you for doing the change :)
> org.apache.aries.util pom should point to java6-parent, not java5-parent
> ------------------------------------------------------------------------
>
> Key: ARIES-708
> URL: https://issues.apache.org/jira/browse/ARIES-708
> Project: Aries
> Issue Type: Bug
> Components: Util
> Affects Versions: 0.4
> Reporter: John Ross
> Assignee: John Ross
> Fix For: 0.4
>
>
> Pulled in org.apache.aries.util using m2e and received a bunch of errors about the @Override annotation use on implemented interface methods. Parent should be java6-parent.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ARIES-708) org.apache.aries.util pom should
point to java6-parent, not java5-parent
Posted by "John Ross (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063948#comment-13063948 ]
John Ross commented on ARIES-708:
---------------------------------
Within the util pom, I changed the parent back to java5-parent. Within the java5-parent pom, I changed the source from 1.5 to 1.6. This results in no compile errors on the util project.
Within the util project, I wrote a quick test class that used Properties.store(Writer, String), which is new to 1.6. Because I'm using a 1.6 compiler, there were no workspace indications that anything was wrong. However, when I performed a maven build with goal install, it errored out with
[ERROR] Undefined reference: java/util/Properties.store(Ljava/io/Writer;Ljava/lang/String;)V in C:\cygwin\home\jwross@us.ibm.com\aries\util\target\classes\org\apache\aries\util\temp\Test.class
[WARNING] Rule 0: org.codehaus.mojo.animal_sniffer.enforcer.CheckSignatureRule failed with message:
Signature errors found. Verify them and put @IgnoreJRERequirement on them.
So everything looks good as far as I can see. Without objection, I'll commit the changes.
> org.apache.aries.util pom should point to java6-parent, not java5-parent
> ------------------------------------------------------------------------
>
> Key: ARIES-708
> URL: https://issues.apache.org/jira/browse/ARIES-708
> Project: Aries
> Issue Type: Bug
> Components: Util
> Affects Versions: 0.4
> Reporter: John Ross
> Assignee: John Ross
> Fix For: 0.4
>
>
> Pulled in org.apache.aries.util using m2e and received a bunch of errors about the @Override annotation use on implemented interface methods. Parent should be java6-parent.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ARIES-708) org.apache.aries.util pom should
point to java6-parent, not java5-parent
Posted by "Valentin Mahrwald (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063933#comment-13063933 ]
Valentin Mahrwald commented on ARIES-708:
-----------------------------------------
Sounds like a very good plan.
The main reason I had changed util to use the java5-parent is that it is used by many other modules so being able to be run on Java 5 is quite useful (I know of at least one consumer who has that requirement). However, Aries has not been buildable on an actual Java5 machine for quite some while. So changing the source level should be absolutely fine.
> org.apache.aries.util pom should point to java6-parent, not java5-parent
> ------------------------------------------------------------------------
>
> Key: ARIES-708
> URL: https://issues.apache.org/jira/browse/ARIES-708
> Project: Aries
> Issue Type: Bug
> Components: Util
> Affects Versions: 0.4
> Reporter: John Ross
> Assignee: John Ross
> Fix For: 0.4
>
>
> Pulled in org.apache.aries.util using m2e and received a bunch of errors about the @Override annotation use on implemented interface methods. Parent should be java6-parent.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ARIES-708) org.apache.aries.util pom should
point to java6-parent, not java5-parent
Posted by "Alasdair Nottingham (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063925#comment-13063925 ]
Alasdair Nottingham commented on ARIES-708:
-------------------------------------------
Based on Valentin's comment I think we have this situation where you can't build aries with a Java 5 SDK because too much needs Java 6, but some things we want to run on Java 5. Right now we get into this kind of problem where @Overrides are added which work, because you use the Java 6 compiler, but break those who enforce the Java 5 rules (mainly m2e).
If we changed the Java 5 parent so it accepted Java 6 source, but kept everything else the same I would hope it would ensure compatibility with Java 5 JVMs (even when compiling using Java 6) but also allow @Override.
Thoughts?
> org.apache.aries.util pom should point to java6-parent, not java5-parent
> ------------------------------------------------------------------------
>
> Key: ARIES-708
> URL: https://issues.apache.org/jira/browse/ARIES-708
> Project: Aries
> Issue Type: Bug
> Components: Util
> Affects Versions: 0.4
> Reporter: John Ross
> Assignee: John Ross
> Fix For: 0.4
>
>
> Pulled in org.apache.aries.util using m2e and received a bunch of errors about the @Override annotation use on implemented interface methods. Parent should be java6-parent.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ARIES-708) org.apache.aries.util pom should point
to java6-parent, not java5-parent
Posted by "Jeremy Hughes (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Hughes updated ARIES-708:
--------------------------------
Fix Version/s: util-0.4
> org.apache.aries.util pom should point to java6-parent, not java5-parent
> ------------------------------------------------------------------------
>
> Key: ARIES-708
> URL: https://issues.apache.org/jira/browse/ARIES-708
> Project: Aries
> Issue Type: Bug
> Components: Util
> Affects Versions: 0.4
> Reporter: John Ross
> Assignee: John Ross
> Fix For: parent-0.5.0, util-0.4
>
>
> Pulled in org.apache.aries.util using m2e and received a bunch of errors about the @Override annotation use on implemented interface methods. Parent should be java6-parent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ARIES-708) org.apache.aries.util pom should
point to java6-parent, not java5-parent
Posted by "Valentin Mahrwald (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064457#comment-13064457 ]
Valentin Mahrwald commented on ARIES-708:
-----------------------------------------
That is really annoying. I could not find a way round either and most disturbingly javac -source 1.6 -target 1.5 also complains so this is not purely a maven problem ...
I have taken out the @Override annotations for this project and hope to get round to doing the other ones, but as far as I recall util was the worst offender.
> org.apache.aries.util pom should point to java6-parent, not java5-parent
> ------------------------------------------------------------------------
>
> Key: ARIES-708
> URL: https://issues.apache.org/jira/browse/ARIES-708
> Project: Aries
> Issue Type: Bug
> Components: Util
> Affects Versions: 0.4
> Reporter: John Ross
> Assignee: John Ross
> Fix For: 0.4
>
>
> Pulled in org.apache.aries.util using m2e and received a bunch of errors about the @Override annotation use on implemented interface methods. Parent should be java6-parent.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (ARIES-708) org.apache.aries.util pom should
point to java6-parent, not java5-parent
Posted by "John Ross (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Ross resolved ARIES-708.
-----------------------------
Resolution: Fixed
Committed changes to trunk.
> org.apache.aries.util pom should point to java6-parent, not java5-parent
> ------------------------------------------------------------------------
>
> Key: ARIES-708
> URL: https://issues.apache.org/jira/browse/ARIES-708
> Project: Aries
> Issue Type: Bug
> Components: Util
> Affects Versions: 0.4
> Reporter: John Ross
> Assignee: John Ross
> Fix For: 0.4
>
>
> Pulled in org.apache.aries.util using m2e and received a bunch of errors about the @Override annotation use on implemented interface methods. Parent should be java6-parent.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ARIES-708) org.apache.aries.util pom should
point to java6-parent, not java5-parent
Posted by "John Ross (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064209#comment-13064209 ]
John Ross commented on ARIES-708:
---------------------------------
Executing 1.6 javac (which is what the build uses) without the -source parameter and with a -target parameter of 1.5 seems to have the desired result. However, I see no way to suppress the -source parameter at build time. It's always there even if removed from all poms (which gives it a value of 1.3) and, in any case, must be there with a value of 1.6 in order for m2e to create the project settings correctly.
I don't see any other way at this point to resolve this but to remove the @Override annotations from the interface methods, as suggested previously.
> org.apache.aries.util pom should point to java6-parent, not java5-parent
> ------------------------------------------------------------------------
>
> Key: ARIES-708
> URL: https://issues.apache.org/jira/browse/ARIES-708
> Project: Aries
> Issue Type: Bug
> Components: Util
> Affects Versions: 0.4
> Reporter: John Ross
> Assignee: John Ross
> Fix For: 0.4
>
>
> Pulled in org.apache.aries.util using m2e and received a bunch of errors about the @Override annotation use on implemented interface methods. Parent should be java6-parent.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (ARIES-708) org.apache.aries.util pom should
point to java6-parent, not java5-parent
Posted by "John Ross (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Ross reopened ARIES-708:
-----------------------------
Hi, I don't have any issues with that. My understanding was the standard procedure was to use java6-parent on all projects and remove @Overrides from the implemented interface methods if someone had to use a java 5 compiler and complained.
Are you saying the preferred procedure is to use java5-parent on all projects that are java 5 compatible or is this a special rule for the util project? Are there certain projects that must be java 5 compatible?
> org.apache.aries.util pom should point to java6-parent, not java5-parent
> ------------------------------------------------------------------------
>
> Key: ARIES-708
> URL: https://issues.apache.org/jira/browse/ARIES-708
> Project: Aries
> Issue Type: Bug
> Components: Util
> Affects Versions: 0.4
> Reporter: John Ross
> Assignee: John Ross
> Fix For: 0.4
>
>
> Pulled in org.apache.aries.util using m2e and received a bunch of errors about the @Override annotation use on implemented interface methods. Parent should be java6-parent.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (ARIES-708) org.apache.aries.util pom should
point to java6-parent, not java5-parent
Posted by "John Ross (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Ross resolved ARIES-708.
-----------------------------
Resolution: Fixed
Fixed by removing @Override annotations from implemented interface methods.
See http://svn.apache.org/viewvc?rev=1145930&view=rev.
> org.apache.aries.util pom should point to java6-parent, not java5-parent
> ------------------------------------------------------------------------
>
> Key: ARIES-708
> URL: https://issues.apache.org/jira/browse/ARIES-708
> Project: Aries
> Issue Type: Bug
> Components: Util
> Affects Versions: 0.4
> Reporter: John Ross
> Assignee: John Ross
> Fix For: 0.4
>
>
> Pulled in org.apache.aries.util using m2e and received a bunch of errors about the @Override annotation use on implemented interface methods. Parent should be java6-parent.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (ARIES-708) org.apache.aries.util pom should
point to java6-parent, not java5-parent
Posted by "John Ross (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Ross reopened ARIES-708:
-----------------------------
Well, that obviously didn't work. javac apparently has problems when -source and -target differ. I'm going to revert the changes and leave the util project pointing to java5-parent until this can be investigated further..
> org.apache.aries.util pom should point to java6-parent, not java5-parent
> ------------------------------------------------------------------------
>
> Key: ARIES-708
> URL: https://issues.apache.org/jira/browse/ARIES-708
> Project: Aries
> Issue Type: Bug
> Components: Util
> Affects Versions: 0.4
> Reporter: John Ross
> Assignee: John Ross
> Fix For: 0.4
>
>
> Pulled in org.apache.aries.util using m2e and received a bunch of errors about the @Override annotation use on implemented interface methods. Parent should be java6-parent.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ARIES-708) org.apache.aries.util pom should
point to java6-parent, not java5-parent
Posted by "Valentin Mahrwald (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063753#comment-13063753 ]
Valentin Mahrwald commented on ARIES-708:
-----------------------------------------
Well :)
The code in util is Java 5 compatible, even though the use of @Override annotations means that it needs a java 6 compiler. With the java5 parent there is a check included to make we don't break Java 5 compatibility, which is missing when using the java6-parent.
So maybe the better fix is to remove the interface @Overrides.
What do you think?
> org.apache.aries.util pom should point to java6-parent, not java5-parent
> ------------------------------------------------------------------------
>
> Key: ARIES-708
> URL: https://issues.apache.org/jira/browse/ARIES-708
> Project: Aries
> Issue Type: Bug
> Components: Util
> Affects Versions: 0.4
> Reporter: John Ross
> Assignee: John Ross
> Fix For: 0.4
>
>
> Pulled in org.apache.aries.util using m2e and received a bunch of errors about the @Override annotation use on implemented interface methods. Parent should be java6-parent.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira