You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/09/16 18:38:07 UTC

[GitHub] [superset] eschutho commented on a diff in pull request #20903: feat: add header_data into emails

eschutho commented on code in PR #20903:
URL: https://github.com/apache/superset/pull/20903#discussion_r973296424


##########
superset/reports/notifications/base.py:
##########
@@ -21,11 +21,13 @@
 import pandas as pd
 
 from superset.reports.models import ReportRecipients, ReportRecipientType
+from superset.utils.core import HeaderDataType
 
 
 @dataclass
 class NotificationContent:
     name: str
+    header_data: HeaderDataType  # this is optional to account for error states

Review Comment:
   @AAfghahi it looks like this value is always being passed into the class. Can we just remove the comment or is there some other intention here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org