You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "rhopman (via GitHub)" <gi...@apache.org> on 2026/09/18 11:21:47 UTC
[PR] FINERACT-2844: Fix PostgreSQL standing instruction loan-dues query [fineract]
rhopman opened a new pull request, #6478:
URL: https://github.com/apache/fineract/pull/6478
## Description
Updates the Execute Standing Instruction job to use a database-compatible boolean predicate when retrieving incomplete loan repayment schedules. This prevents PostgreSQL’s `boolean <> integer` error while preserving MySQL and MariaDB compatibility.
Adds PostgreSQL coverage verifying that outstanding loan dues are calculated from due, incomplete installments while completed and future installments are excluded.
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made.
- [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute).
- [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.
- [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy).
Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2844: Fix PostgreSQL standing instruction loan-dues query [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #6478:
URL: https://github.com/apache/fineract/pull/6478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2844: Fix PostgreSQL standing instruction loan-dues query [fineract]
Posted by "Abhishek6122008 (via GitHub)" <gi...@apache.org>.
Abhishek6122008 commented on PR #6478:
URL: https://github.com/apache/fineract/pull/6478#issuecomment-6174564952
@rhopman This is already fixed on develop by #6235 (FINERACT-2743), which is why it conflicts. Anything left here after a rebase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2844: Fix PostgreSQL standing instruction loan-dues query [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #6478:
URL: https://github.com/apache/fineract/pull/6478#issuecomment-6188978702
@rhopman Please rebase (sorry for being so slow on the review :( )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2844: Fix PostgreSQL standing instruction loan-dues query [fineract]
Posted by "rhopman (via GitHub)" <gi...@apache.org>.
rhopman commented on PR #6478:
URL: https://github.com/apache/fineract/pull/6478#issuecomment-6189450777
Thanks @Abhishek6122008 and @adamsaghy, I confirmed that #6235 already fixes the query. After rebasing, this PR only adds PostgreSQL regression coverage for the loan-dues query, including the outstanding amount calculation and exclusion of completed and future installments. The test passes against the existing fix.
I'll leave it up to you if you still want to merge the PR for the extra test coverage, or discard it. Either way is fine with me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org