You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morrySnow (via GitHub)" <gi...@apache.org> on 2023/04/14 08:37:04 UTC

[GitHub] [doris] morrySnow commented on a diff in pull request #18596: [enhancement](Nereids) optimize bloom filter size reducing strategy

morrySnow commented on code in PR #18596:
URL: https://github.com/apache/doris/pull/18596#discussion_r1166496454


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/stats/StatsMathUtil.java:
##########
@@ -59,4 +64,21 @@ public static double divide(double a, double b) {
         return a / nonZeroDivisor(b);
     }
 
+    /**
+     * compute the multi columns unite ndv
+     */
+    public static double multiNdv(List<Double> ndvs) {
+        if (CollectionUtils.isEmpty(ndvs)) {
+            return -1;

Review Comment:
   i don't think 0 is a good idea, if we return 0 when we have no column stats, then the bloom filter size will significantly smaller than the actual demand
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org