You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "JoshRosen (via GitHub)" <gi...@apache.org> on 2024/09/06 22:55:10 UTC
Re: [PR] [SPARK-42204][CORE] Add option to disable redundant logging of TaskMetrics internal accumulators in event logs [spark]
JoshRosen commented on PR #39763:
URL: https://github.com/apache/spark/pull/39763#issuecomment-2334915063
I pushed an empty commit to retest this. The only failing test is `org.apache.spark.storage.BlockManagerDecommissionIntegrationSuite` which was preexistingly flaky for reasons unrelated to this change.
Since I've been so delayed in actually merging this, I took another look to see if any intervening changes might have introduced logical conflicts but I didn't spot any potentially problematic changes.
Especially given that this is flagged-off-by-default opt-in functionality, I feel that this is a low-risk change.
Therefore I'm going to merge this now (finally!). In separate followups I may end up building on the configuration-plumbing infrastructure introduced here to add other opt-in size reduction optimizations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org