You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Julian Hyde (JIRA)" <ji...@apache.org> on 2016/10/24 22:35:59 UTC

[jira] [Resolved] (CALCITE-1461) Hard-coded class name in JaninoRelMetadataProvider breaks shading

     [ https://issues.apache.org/jira/browse/CALCITE-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Hyde resolved CALCITE-1461.
----------------------------------
       Resolution: Fixed
    Fix Version/s: 1.11.0

Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/3e886e9e. Thanks for the PR, [~jark]!

> Hard-coded class name in JaninoRelMetadataProvider breaks shading
> -----------------------------------------------------------------
>
>                 Key: CALCITE-1461
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1461
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Jark Wu
>            Assignee: Julian Hyde
>             Fix For: 1.11.0
>
>
> In {{JaninoRelMetadataProvider.load3}}, the generated class string contains some hard coded Calcite's classes, such as {{org.apache.calcite.rel.metadata.MetadataDef}}. After shading Calcite, the MetadataDef can not be found in the shaded classes. And a compile error will be thrown.
> So it's better to use {{MetadataDef.class.getName()}} to replace the hard code string.
> I'm appreciate to make a PR if you want. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)