[jira] [Commented] (NIFI-2917) Release capture of keyboard shortcuts when UI client is disconnected from server to allow Ctrl/Cmd + R for refresh

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-2917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15767739#comment-15767739 ] 

ASF GitHub Bot commented on NIFI-2917:
--------------------------------------

GitHub user scottyaslan opened a pull request:

    https://github.com/apache/nifi/pull/1351

    [NIFI-2917] disable canvas refresh after ajax error and allow page re…

    …fresh
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/scottyaslan/nifi NIFI-2917

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1351.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1351
    
----
commit 8829643a7cbd39caeae508e20af9168ca7780666
Author: Scott Aslan <sc...@gmail.com>
Date:   2016-12-21T15:33:58Z

    [NIFI-2917] disable canvas refresh after ajax error and allow page refresh

----


> Release capture of keyboard shortcuts when UI client is disconnected from server to allow Ctrl/Cmd + R for refresh
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-2917
>                 URL: https://issues.apache.org/jira/browse/NIFI-2917
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core UI
>    Affects Versions: 1.0.0, 0.7.0
>            Reporter: Andy LoPresto
>            Assignee: Scott Aslan
>            Priority: Trivial
>              Labels: easyfix
>
> When a browser window is open and the NiFi UI is loaded, and then the server is stopped, the UI displays a page explaining that the connection is not available. 
> This UI page captures keyboard commands, so when the server is restarted, pressing Ctrl/Cmd + R does not execute the browser's refresh function. Rather, the refresh menu or toolbar item must be invoked using the mouse. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)