[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #1490: IGNITE-18397 Rework Watches based on Raft Learners

[GitBox <gi...@apache.org>]

vldpyatkov commented on code in PR #1490:
URL: https://github.com/apache/ignite-3/pull/1490#discussion_r1065031135


##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java:
##########
@@ -125,7 +142,8 @@ public class RocksDbKeyValueStorage implements KeyValueStorage {
     private final ReadWriteLock rwLock = new ReentrantReadWriteLock();
 
     /** Thread-pool for snapshot operations execution. */
-    private final ExecutorService snapshotExecutor = Executors.newFixedThreadPool(2);
+    private final ExecutorService snapshotExecutor =
+            Executors.newFixedThreadPool(2, new NamedThreadFactory("metastorage-snapshot-executor", LOG));

Review Comment:
   Required to add a node name to the tread pool prefix.



##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java:
##########
@@ -151,6 +169,43 @@ public class RocksDbKeyValueStorage implements KeyValueStorage {
     /** Update counter. Will be incremented for each update of any particular entry. */
     private volatile long updCntr;
 
+    /** Executor for processing watch events. */
+    private final ExecutorService watchExecutor =
+            Executors.newSingleThreadExecutor(new NamedThreadFactory("metastorage-watch-executor", LOG));

Review Comment:
   Required to add a node name to the tread pool prefix.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org