You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ChengJie1053 (via GitHub)" <gi...@apache.org> on 2024/06/15 04:37:31 UTC
[PR] [FLINK-34908][pipeline-connector][starrocks] Fix MySQL to doris pipeline will lose precision for timestamp type [flink-cdc]
ChengJie1053 opened a new pull request, #3417:
URL: https://github.com/apache/flink-cdc/pull/3417
https://github.com/apache/flink-cdc/pull/3207
I found this code while learning the flink cdc source code, I think starrocks may have similar problems, if this piece has been done, I will close the pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34908][pipeline-connector][starrocks] Fix MySQL to doris pipeline will lose precision for timestamp type [flink-cdc]
Posted by "ChengJie1053 (via GitHub)" <gi...@apache.org>.
ChengJie1053 closed pull request #3417: [FLINK-34908][pipeline-connector][starrocks] Fix MySQL to doris pipeline will lose precision for timestamp type
URL: https://github.com/apache/flink-cdc/pull/3417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34908][pipeline-connector][starrocks] Fix MySQL to doris pipeline will lose precision for timestamp type [flink-cdc]
Posted by "ChengJie1053 (via GitHub)" <gi...@apache.org>.
ChengJie1053 commented on PR #3417:
URL: https://github.com/apache/flink-cdc/pull/3417#issuecomment-2174850613
> @ChengJie1053 https://issues.apache.org/jira/projects/FLINK/issues/FLINK-34908?filter=allissues Hello, I found starrocks only support second level precision, so I did't modify starrocks pipeline. I added comment in issue. You can visit link https://docs.starrocks.io/zh/docs/sql-reference/data-types/date-types/DATETIME/
Okay, thank you. Thank you for your guidance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34908][pipeline-connector][starrocks] Fix MySQL to doris pipeline will lose precision for timestamp type [flink-cdc]
Posted by "yuxiqian (via GitHub)" <gi...@apache.org>.
yuxiqian commented on PR #3417:
URL: https://github.com/apache/flink-cdc/pull/3417#issuecomment-2172008618
Thanks for @ChengJie1053's great work, could you please add some test cases to verify this change? Also some existed testcases might need to be tweaked to reflect this change:
```diff
Error: Failures:
Error: EventRecordSerializationSchemaTest.testMixedSchemaAndDataChanges:133->verifySerializeResult:275
+expected:<{__op=0, col1=1, col2=true, col3=2023-11-27 18:00:00}>
- but was:<{__op=0, col1=1, col2=true, col3=2023-11-27 18:00:00.000000}>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34908][pipeline-connector][starrocks] Fix MySQL to doris pipeline will lose precision for timestamp type [flink-cdc]
Posted by "gong (via GitHub)" <gi...@apache.org>.
gong commented on PR #3417:
URL: https://github.com/apache/flink-cdc/pull/3417#issuecomment-2174846031
@ChengJie1053 https://issues.apache.org/jira/projects/FLINK/issues/FLINK-34908?filter=allissues Hello, I found starrocks only support second level precision, so I did't modify starrocks pipeline. I added comment in issue. You can visit link https://docs.starrocks.io/zh/docs/sql-reference/data-types/date-types/DATETIME/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34908][pipeline-connector][starrocks] Fix MySQL to doris pipeline will lose precision for timestamp type [flink-cdc]
Posted by "ChengJie1053 (via GitHub)" <gi...@apache.org>.
ChengJie1053 commented on PR #3417:
URL: https://github.com/apache/flink-cdc/pull/3417#issuecomment-2172020816
> Thanks for @ChengJie1053's great work, could you please add some tests to verify this change? Also some existing testcases might need to be tweaked to reflect this change:
>
> ```diff
> Error: Failures:
> Error: EventRecordSerializationSchemaTest.testMixedSchemaAndDataChanges:133->verifySerializeResult:275
>
> +expected:<{__op=0, col1=1, col2=true, col3=2023-11-27 18:00:00}>
> - but was:<{__op=0, col1=1, col2=true, col3=2023-11-27 18:00:00.000000}>
> ```
Ok, thanks for reviewing the code for me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org