You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/30 15:57:54 UTC

[GitHub] [pulsar] merlimat commented on a change in pull request #11839: [stats] Add Key_Shared metadata to topic stats

merlimat commented on a change in pull request #11839:
URL: https://github.com/apache/pulsar/pull/11839#discussion_r698609295



##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/stats/SubscriptionStatsImpl.java
##########
@@ -103,6 +103,12 @@
     /** Mark that the subscription state is kept in sync across different regions. */
     public boolean isReplicated;
 
+    /** Whether out of order delivery is allowed on the Key_Shared subscription. */
+    public boolean allowOutOfOrderDelivery;

Review comment:
       This should also be added to the `SubscriptionStats` interface. 
   
   Also, since this is specific to KeyShared subscriptions, it might get confusing when using other subscription types. We could instead introduce a sub-interface/sub-object to show the key-shared policy. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org