You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by sebb <se...@gmail.com> on 2011/03/30 03:30:42 UTC

Re: svn commit: r1086810 - /commons/proper/pool/branches/POOL_1_X/pom.xml

On 30 March 2011 01:13,  <ps...@apache.org> wrote:
> Author: psteitz
> Date: Wed Mar 30 00:13:51 2011
> New Revision: 1086810
>
> URL: http://svn.apache.org/viewvc?rev=1086810&view=rev
> Log:
> Upgraded parent pom, downgraded assembly plugin to working version.

What is the exact problem? I'm happy to raise a bug and create test
cases etc., but I don't know what the issue is.


> Modified:
>    commons/proper/pool/branches/POOL_1_X/pom.xml
>
> Modified: commons/proper/pool/branches/POOL_1_X/pom.xml
> URL: http://svn.apache.org/viewvc/commons/proper/pool/branches/POOL_1_X/pom.xml?rev=1086810&r1=1086809&r2=1086810&view=diff
> ==============================================================================
> --- commons/proper/pool/branches/POOL_1_X/pom.xml (original)
> +++ commons/proper/pool/branches/POOL_1_X/pom.xml Wed Mar 30 00:13:51 2011
> @@ -22,7 +22,7 @@
>   <parent>
>     <groupId>org.apache.commons</groupId>
>     <artifactId>commons-parent</artifactId>
> -    <version>17</version>
> +    <version>20</version>
>   </parent>
>   <modelVersion>4.0.0</modelVersion>
>   <groupId>commons-pool</groupId>
> @@ -148,6 +148,10 @@
>           <artifactId>maven-source-plugin</artifactId>
>           <version>2.1</version>
>         </plugin>
> +        <plugin>
> +          <artifactId>maven-assembly-plugin</artifactId>
> +          <version>2.2-beta-5</version>
> +        </plugin>
>       </plugins>
>     </pluginManagement>
>     <sourceDirectory>src/java</sourceDirectory>
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r1086810 - /commons/proper/pool/branches/POOL_1_X/pom.xml

Posted by sebb <se...@gmail.com>.
On 31 March 2011 12:36, Niall Pemberton <ni...@gmail.com> wrote:
> On Thu, Mar 31, 2011 at 2:46 AM, sebb <se...@gmail.com> wrote:
>> On 31 March 2011 02:00, Niall Pemberton <ni...@gmail.com> wrote:
>>> On Wed, Mar 30, 2011 at 6:30 AM, Phil Steitz <ph...@gmail.com> wrote:
>>>> On 3/29/11 6:30 PM, sebb wrote:
>>>>> On 30 March 2011 01:13,  <ps...@apache.org> wrote:
>>>>>> Author: psteitz
>>>>>> Date: Wed Mar 30 00:13:51 2011
>>>>>> New Revision: 1086810
>>>>>>
>>>>>> URL: http://svn.apache.org/viewvc?rev=1086810&view=rev
>>>>>> Log:
>>>>>> Upgraded parent pom, downgraded assembly plugin to working version.
>>>>> What is the exact problem? I'm happy to raise a bug and create test
>>>>> cases etc., but I don't know what the issue is.
>>>>
>>>> Per Niall's comments during the vote on parent 19 or 20,  with the
>>>> later version of the assembly plugin in the current Commons parent
>>>> mvn -Prc -DcreateChecksum=true install
>>>> does not create, sign and install the tars/zips to the local repo.
>>>
>>> I found that doing "mvn -Prc install" didn't work - but adding clean
>>> (i.e.  "mvn -Prc clean install") caused it to work just fine.
>>
>> Odd, why should clean work?
>
> Dunno, I speculated here:
>
> http://markmail.org/message/ilbfryofhsqblwa7
>

Looks like the assembly plugin is ignoring the parent pom goal
attachment in the rc profile, because 2.2[.1] work fine if that
section of the profile is copied to the component pom.

[Clearly the assembly plugin has grown up into a stroppy teenager that
ignores its parent !]

I've updated the JIRA accordingly

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r1086810 - /commons/proper/pool/branches/POOL_1_X/pom.xml

Posted by Niall Pemberton <ni...@gmail.com>.
On Thu, Mar 31, 2011 at 2:46 AM, sebb <se...@gmail.com> wrote:
> On 31 March 2011 02:00, Niall Pemberton <ni...@gmail.com> wrote:
>> On Wed, Mar 30, 2011 at 6:30 AM, Phil Steitz <ph...@gmail.com> wrote:
>>> On 3/29/11 6:30 PM, sebb wrote:
>>>> On 30 March 2011 01:13,  <ps...@apache.org> wrote:
>>>>> Author: psteitz
>>>>> Date: Wed Mar 30 00:13:51 2011
>>>>> New Revision: 1086810
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=1086810&view=rev
>>>>> Log:
>>>>> Upgraded parent pom, downgraded assembly plugin to working version.
>>>> What is the exact problem? I'm happy to raise a bug and create test
>>>> cases etc., but I don't know what the issue is.
>>>
>>> Per Niall's comments during the vote on parent 19 or 20,  with the
>>> later version of the assembly plugin in the current Commons parent
>>> mvn -Prc -DcreateChecksum=true install
>>> does not create, sign and install the tars/zips to the local repo.
>>
>> I found that doing "mvn -Prc install" didn't work - but adding clean
>> (i.e.  "mvn -Prc clean install") caused it to work just fine.
>
> Odd, why should clean work?

Dunno, I speculated here:

http://markmail.org/message/ilbfryofhsqblwa7

Niall

> I found that
>
> mvn -Prc package install
>
> works, but that makes a bit more sense as the package presumably needs
> to attach the goal.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r1086810 - /commons/proper/pool/branches/POOL_1_X/pom.xml

Posted by sebb <se...@gmail.com>.
On 31 March 2011 02:00, Niall Pemberton <ni...@gmail.com> wrote:
> On Wed, Mar 30, 2011 at 6:30 AM, Phil Steitz <ph...@gmail.com> wrote:
>> On 3/29/11 6:30 PM, sebb wrote:
>>> On 30 March 2011 01:13,  <ps...@apache.org> wrote:
>>>> Author: psteitz
>>>> Date: Wed Mar 30 00:13:51 2011
>>>> New Revision: 1086810
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1086810&view=rev
>>>> Log:
>>>> Upgraded parent pom, downgraded assembly plugin to working version.
>>> What is the exact problem? I'm happy to raise a bug and create test
>>> cases etc., but I don't know what the issue is.
>>
>> Per Niall's comments during the vote on parent 19 or 20,  with the
>> later version of the assembly plugin in the current Commons parent
>> mvn -Prc -DcreateChecksum=true install
>> does not create, sign and install the tars/zips to the local repo.
>
> I found that doing "mvn -Prc install" didn't work - but adding clean
> (i.e.  "mvn -Prc clean install") caused it to work just fine.

Odd, why should clean work?

I found that

mvn -Prc package install

works, but that makes a bit more sense as the package presumably needs
to attach the goal.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r1086810 - /commons/proper/pool/branches/POOL_1_X/pom.xml

Posted by Niall Pemberton <ni...@gmail.com>.
On Wed, Mar 30, 2011 at 6:30 AM, Phil Steitz <ph...@gmail.com> wrote:
> On 3/29/11 6:30 PM, sebb wrote:
>> On 30 March 2011 01:13,  <ps...@apache.org> wrote:
>>> Author: psteitz
>>> Date: Wed Mar 30 00:13:51 2011
>>> New Revision: 1086810
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1086810&view=rev
>>> Log:
>>> Upgraded parent pom, downgraded assembly plugin to working version.
>> What is the exact problem? I'm happy to raise a bug and create test
>> cases etc., but I don't know what the issue is.
>
> Per Niall's comments during the vote on parent 19 or 20,  with the
> later version of the assembly plugin in the current Commons parent
> mvn -Prc -DcreateChecksum=true install
> does not create, sign and install the tars/zips to the local repo.

I found that doing "mvn -Prc install" didn't work - but adding clean
(i.e.  "mvn -Prc clean install") caused it to work just fine.

Niall

> Phil
>>
>>> Modified:
>>>    commons/proper/pool/branches/POOL_1_X/pom.xml
>>>
>>> Modified: commons/proper/pool/branches/POOL_1_X/pom.xml
>>> URL: http://svn.apache.org/viewvc/commons/proper/pool/branches/POOL_1_X/pom.xml?rev=1086810&r1=1086809&r2=1086810&view=diff
>>> ==============================================================================
>>> --- commons/proper/pool/branches/POOL_1_X/pom.xml (original)
>>> +++ commons/proper/pool/branches/POOL_1_X/pom.xml Wed Mar 30 00:13:51 2011
>>> @@ -22,7 +22,7 @@
>>>   <parent>
>>>     <groupId>org.apache.commons</groupId>
>>>     <artifactId>commons-parent</artifactId>
>>> -    <version>17</version>
>>> +    <version>20</version>
>>>   </parent>
>>>   <modelVersion>4.0.0</modelVersion>
>>>   <groupId>commons-pool</groupId>
>>> @@ -148,6 +148,10 @@
>>>           <artifactId>maven-source-plugin</artifactId>
>>>           <version>2.1</version>
>>>         </plugin>
>>> +        <plugin>
>>> +          <artifactId>maven-assembly-plugin</artifactId>
>>> +          <version>2.2-beta-5</version>
>>> +        </plugin>
>>>       </plugins>
>>>     </pluginManagement>
>>>     <sourceDirectory>src/java</sourceDirectory>
>>>
>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r1086810 - /commons/proper/pool/branches/POOL_1_X/pom.xml

Posted by sebb <se...@gmail.com>.
On 30 March 2011 06:30, Phil Steitz <ph...@gmail.com> wrote:
> On 3/29/11 6:30 PM, sebb wrote:
>> On 30 March 2011 01:13,  <ps...@apache.org> wrote:
>>> Author: psteitz
>>> Date: Wed Mar 30 00:13:51 2011
>>> New Revision: 1086810
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1086810&view=rev
>>> Log:
>>> Upgraded parent pom, downgraded assembly plugin to working version.
>> What is the exact problem? I'm happy to raise a bug and create test
>> cases etc., but I don't know what the issue is.
>
> Per Niall's comments during the vote on parent 19 or 20,  with the
> later version of the assembly plugin in the current Commons parent
> mvn -Prc -DcreateChecksum=true install
> does not create, sign and install the tars/zips to the local repo.

Of course - sorry, I remember now.

> Phil
>>
>>> Modified:
>>>    commons/proper/pool/branches/POOL_1_X/pom.xml
>>>
>>> Modified: commons/proper/pool/branches/POOL_1_X/pom.xml
>>> URL: http://svn.apache.org/viewvc/commons/proper/pool/branches/POOL_1_X/pom.xml?rev=1086810&r1=1086809&r2=1086810&view=diff
>>> ==============================================================================
>>> --- commons/proper/pool/branches/POOL_1_X/pom.xml (original)
>>> +++ commons/proper/pool/branches/POOL_1_X/pom.xml Wed Mar 30 00:13:51 2011
>>> @@ -22,7 +22,7 @@
>>>   <parent>
>>>     <groupId>org.apache.commons</groupId>
>>>     <artifactId>commons-parent</artifactId>
>>> -    <version>17</version>
>>> +    <version>20</version>
>>>   </parent>
>>>   <modelVersion>4.0.0</modelVersion>
>>>   <groupId>commons-pool</groupId>
>>> @@ -148,6 +148,10 @@
>>>           <artifactId>maven-source-plugin</artifactId>
>>>           <version>2.1</version>
>>>         </plugin>
>>> +        <plugin>
>>> +          <artifactId>maven-assembly-plugin</artifactId>
>>> +          <version>2.2-beta-5</version>
>>> +        </plugin>
>>>       </plugins>
>>>     </pluginManagement>
>>>     <sourceDirectory>src/java</sourceDirectory>
>>>
>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r1086810 - /commons/proper/pool/branches/POOL_1_X/pom.xml

Posted by sebb <se...@gmail.com>.
On 30 March 2011 06:30, Phil Steitz <ph...@gmail.com> wrote:
> On 3/29/11 6:30 PM, sebb wrote:
>> On 30 March 2011 01:13,  <ps...@apache.org> wrote:
>>> Author: psteitz
>>> Date: Wed Mar 30 00:13:51 2011
>>> New Revision: 1086810
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1086810&view=rev
>>> Log:
>>> Upgraded parent pom, downgraded assembly plugin to working version.
>> What is the exact problem? I'm happy to raise a bug and create test
>> cases etc., but I don't know what the issue is.
>
> Per Niall's comments during the vote on parent 19 or 20,  with the
> later version of the assembly plugin in the current Commons parent
> mvn -Prc -DcreateChecksum=true install
> does not create, sign and install the tars/zips to the local repo.

http://jira.codehaus.org/browse/MASSEMBLY-553

The basic problem seems to be that the assembly plugin does not
process the attached descriptors.
This then affects the signing and installation.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r1086810 - /commons/proper/pool/branches/POOL_1_X/pom.xml

Posted by Phil Steitz <ph...@gmail.com>.
On 3/29/11 6:30 PM, sebb wrote:
> On 30 March 2011 01:13,  <ps...@apache.org> wrote:
>> Author: psteitz
>> Date: Wed Mar 30 00:13:51 2011
>> New Revision: 1086810
>>
>> URL: http://svn.apache.org/viewvc?rev=1086810&view=rev
>> Log:
>> Upgraded parent pom, downgraded assembly plugin to working version.
> What is the exact problem? I'm happy to raise a bug and create test
> cases etc., but I don't know what the issue is.

Per Niall's comments during the vote on parent 19 or 20,  with the
later version of the assembly plugin in the current Commons parent
mvn -Prc -DcreateChecksum=true install
does not create, sign and install the tars/zips to the local repo.

Phil
>
>> Modified:
>>    commons/proper/pool/branches/POOL_1_X/pom.xml
>>
>> Modified: commons/proper/pool/branches/POOL_1_X/pom.xml
>> URL: http://svn.apache.org/viewvc/commons/proper/pool/branches/POOL_1_X/pom.xml?rev=1086810&r1=1086809&r2=1086810&view=diff
>> ==============================================================================
>> --- commons/proper/pool/branches/POOL_1_X/pom.xml (original)
>> +++ commons/proper/pool/branches/POOL_1_X/pom.xml Wed Mar 30 00:13:51 2011
>> @@ -22,7 +22,7 @@
>>   <parent>
>>     <groupId>org.apache.commons</groupId>
>>     <artifactId>commons-parent</artifactId>
>> -    <version>17</version>
>> +    <version>20</version>
>>   </parent>
>>   <modelVersion>4.0.0</modelVersion>
>>   <groupId>commons-pool</groupId>
>> @@ -148,6 +148,10 @@
>>           <artifactId>maven-source-plugin</artifactId>
>>           <version>2.1</version>
>>         </plugin>
>> +        <plugin>
>> +          <artifactId>maven-assembly-plugin</artifactId>
>> +          <version>2.2-beta-5</version>
>> +        </plugin>
>>       </plugins>
>>     </pluginManagement>
>>     <sourceDirectory>src/java</sourceDirectory>
>>
>>
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org