You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/02/14 18:37:53 UTC
Review Request: SQOOP-894 Sqoop2: Increase counter and group size in derby
repository
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9448/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
I've increased the size of counter and group name from 50 to 75 and make provide truncating methods into queries, so that they won't fail.
This addresses bug SQOOP-894.
https://issues.apache.org/jira/browse/SQOOP-894
Diffs
-----
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java d94ecc56ae07fab71a0b04223e00984e07b97ce9
Diff: https://reviews.apache.org/r/9448/diff/
Testing
-------
Maven tests seems to be passing + tested on real cluster
Thanks,
Jarek Cecho
Re: Review Request: SQOOP-894 Sqoop2: Increase counter and group size in
derby repository
Posted by Cheolsoo Park <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9448/#review16592
-----------------------------------------------------------
Ship it!
LGTM
- Cheolsoo Park
On Feb. 14, 2013, 5:46 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9448/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2013, 5:46 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've increased the size of counter and group name from 50 to 75 and make provide truncating methods into queries, so that they won't fail.
>
>
> This addresses bug SQOOP-894.
> https://issues.apache.org/jira/browse/SQOOP-894
>
>
> Diffs
> -----
>
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java d94ecc56ae07fab71a0b04223e00984e07b97ce9
>
> Diff: https://reviews.apache.org/r/9448/diff/
>
>
> Testing
> -------
>
> Maven tests seems to be passing + tested on real cluster
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request: SQOOP-894 Sqoop2: Increase counter and group size in
derby repository
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9448/
-----------------------------------------------------------
(Updated Feb. 14, 2013, 5:46 p.m.)
Review request for Sqoop.
Changes
-------
I've improved the select query to also truncate the inputs.
Description
-------
I've increased the size of counter and group name from 50 to 75 and make provide truncating methods into queries, so that they won't fail.
This addresses bug SQOOP-894.
https://issues.apache.org/jira/browse/SQOOP-894
Diffs (updated)
-----
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java d94ecc56ae07fab71a0b04223e00984e07b97ce9
Diff: https://reviews.apache.org/r/9448/diff/
Testing
-------
Maven tests seems to be passing + tested on real cluster
Thanks,
Jarek Cecho