[GitHub] [incubator-pinot] fx19880617 commented on pull request #6246: Adding validation for json_extract_key and json_extract_scalar functions

[GitBox <gi...@apache.org>]

fx19880617 commented on pull request #6246:
URL: https://github.com/apache/incubator-pinot/pull/6246#issuecomment-777379824


   > Why do we have this validation inside the parser? We should have a query validation phase after the query is parsed
   
   The reason is that the current stack trace is very confusing and has no way for users to figure out what's wrong. Those identifiers and literals check will be much useful to help users correct their queries. 
   
   Please let me know if you find some better place to put them.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org