[GitHub] [cordova-js] fb64 opened a new pull request #210: Add fallback to nodejs require method in order to use nodejs module

[GitBox <gi...@apache.org>]

fb64 opened a new pull request #210: Add fallback to nodejs require method in order to use nodejs module
URL: https://github.com/apache/cordova-js/pull/210
 
 
   Add fallback to nodejs require method in order to use nodejs module in electron plugin
   
   Platforms affected
   Electron
   
   Motivation and Context
   Allow using nodejs 'require' method to load nodejs module inside electron platform plugin
   
   Description
   Add fallback to nodejs require method in order to use nodejs module in electron plugin
   
   Testing
   Create an electron plugin that require nodejs module inside, add it to a sample cordova project and check that plugin works and uses nodejs module. 
   
   sample project should use the following electron config
   ```
   {
       "browserWindow": {
           "webPreferences": {
               "nodeIntegration": false
           }
       }
   }
   ```
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org