You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "gszadovszky (via GitHub)" <gi...@apache.org> on 2023/02/15 08:39:30 UTC
[GitHub] [parquet-mr] gszadovszky opened a new pull request, #1027: PARQUET-2243: Support zstd-jni in DirectCodecFactory
gszadovszky opened a new pull request, #1027:
URL: https://github.com/apache/parquet-mr/pull/1027
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-2243
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Enabled executing `parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestDirectCodecFactory` for ZSTD encoding
### Commits
- [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on a diff in pull request #1027: PARQUET-2243: Support zstd-jni in DirectCodecFactory
Posted by "gszadovszky (via GitHub)" <gi...@apache.org>.
gszadovszky commented on code in PR #1027:
URL: https://github.com/apache/parquet-mr/pull/1027#discussion_r1107084792
##########
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/example/TestInputOutputFormat.java:
##########
@@ -66,7 +66,8 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-public class TestInputOutputFormat {
+public class
+TestInputOutputFormat {
Review Comment:
Yes, thanks for the noticing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on pull request #1027: PARQUET-2243: Support zstd-jni in DirectCodecFactory
Posted by "gszadovszky (via GitHub)" <gi...@apache.org>.
gszadovszky commented on PR #1027:
URL: https://github.com/apache/parquet-mr/pull/1027#issuecomment-1432679571
Thank you @wgtmac for the review!
I'll push it tomorrow if are no objections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky merged pull request #1027: PARQUET-2243: Support zstd-jni in DirectCodecFactory
Posted by "gszadovszky (via GitHub)" <gi...@apache.org>.
gszadovszky merged PR #1027:
URL: https://github.com/apache/parquet-mr/pull/1027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] wgtmac commented on a diff in pull request #1027: PARQUET-2243: Support zstd-jni in DirectCodecFactory
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on code in PR #1027:
URL: https://github.com/apache/parquet-mr/pull/1027#discussion_r1108004026
##########
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/example/TestInputOutputFormat.java:
##########
@@ -66,7 +66,8 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-public class TestInputOutputFormat {
+public class
+TestInputOutputFormat {
Review Comment:
Looking good on my side. Thanks @gszadovszky
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] wgtmac commented on a diff in pull request #1027: PARQUET-2243: Support zstd-jni in DirectCodecFactory
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on code in PR #1027:
URL: https://github.com/apache/parquet-mr/pull/1027#discussion_r1107006966
##########
parquet-hadoop/src/test/java/org/apache/parquet/hadoop/example/TestInputOutputFormat.java:
##########
@@ -66,7 +66,8 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-public class TestInputOutputFormat {
+public class
+TestInputOutputFormat {
Review Comment:
Modified by accident?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org