You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/12/09 00:24:00 UTC
[jira] [Commented] (CURATOR-491) PathChildrenCache can process background jobs after being closed

    [ https://issues.apache.org/jira/browse/CURATOR-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713818#comment-16713818 ] 

ASF GitHub Bot commented on CURATOR-491:
----------------------------------------

GitHub user Randgalt opened a pull request:

    https://github.com/apache/curator/pull/289

    [CURATOR-491] PathChildrenCache can process background jobs after being closed

    CURATOR-332 fixed part of this, but there's another background handler that has the same problem.
    The background handler in refresh() correctly checks if the instance has been closed before processing as well as clearing watchers that might have been set in the interim. This same treatment needs to be added to the background handler in getDataAndStat().


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/curator CURATOR-491

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/289.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #289
    
----
commit b0cd91908973ff0b2ec3f5b5d117f51a514d9cd0
Author: randgalt <ra...@...>
Date:   2018-12-09T00:21:07Z

    CURATOR-491
    
    CURATOR-332 fixed part of this, but there's another background handler that has the same problem.
    
    The background handler in {{refresh()}} correctly checks if the instance has been closed before processing as well as clearing watchers that might have been set in the interim. This same treatment needs to be added to the background handler in {{getDataAndStat()}}.

commit aea4086f802a70670a9714a2325a1b6451ddb20e
Author: randgalt <ra...@...>
Date:   2018-12-09T00:22:42Z

    removed debug prints

----


> PathChildrenCache can process background jobs after being closed
> ----------------------------------------------------------------
>
>                 Key: CURATOR-491
>                 URL: https://issues.apache.org/jira/browse/CURATOR-491
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Recipes
>    Affects Versions: 4.0.1
>            Reporter: Jordan Zimmerman
>            Assignee: Jordan Zimmerman
>            Priority: Major
>             Fix For: 4.1.0
>
>
> CURATOR-332 fixed part of this, but there's another background handler that has the same problem.
> The background handler in {{refresh()}} correctly checks if the instance has been closed before processing as well as clearing watchers that might have been set in the interim. This same treatment needs to be added to the background handler in {{getDataAndStat()}}. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)