You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2013/08/21 18:24:59 UTC
svn commit: r1516202 - in /jmeter/trunk: src/core/org/apache/jmeter/gui/
src/core/org/apache/jmeter/gui/util/
src/protocol/http/org/apache/jmeter/protocol/http/modifier/gui/
src/reports/org/apache/jmeter/gui/
src/reports/org/apache/jmeter/report/gui/tr...
Author: pmouawad
Date: Wed Aug 21 16:24:58 2013
New Revision: 1516202
URL: http://svn.apache.org/r1516202
Log:
Bug 55463 - Component.requestFocus() is discouraged; use requestFocusInWindow() instead
Bugzilla Id: 55463
Modified:
jmeter/trunk/src/core/org/apache/jmeter/gui/GuiPackage.java
jmeter/trunk/src/core/org/apache/jmeter/gui/util/FocusRequester.java
jmeter/trunk/src/core/org/apache/jmeter/gui/util/JDateField.java
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/modifier/gui/ParamModifierGui.java
jmeter/trunk/src/reports/org/apache/jmeter/gui/ReportGuiPackage.java
jmeter/trunk/src/reports/org/apache/jmeter/report/gui/tree/ReportTreeListener.java
jmeter/trunk/xdocs/changes.xml
Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/GuiPackage.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/gui/GuiPackage.java?rev=1516202&r1=1516201&r2=1516202&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/gui/GuiPackage.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/gui/GuiPackage.java Wed Aug 21 16:24:58 2013
@@ -597,7 +597,7 @@ public final class GuiPackage implements
popup.pack();
popup.show(invoker, e.getX(), e.getY());
popup.setVisible(true);
- popup.requestFocus();
+ popup.requestFocusInWindow();
}
}
Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/util/FocusRequester.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/gui/util/FocusRequester.java?rev=1516202&r1=1516201&r2=1516202&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/gui/util/FocusRequester.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/gui/util/FocusRequester.java Wed Aug 21 16:24:58 2013
@@ -33,7 +33,7 @@ public class FocusRequester {
SwingUtilities.invokeLater(new Runnable(){
@Override
public void run() {
- comp.requestFocus();
+ comp.requestFocusInWindow();
}
});
}
Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/util/JDateField.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/gui/util/JDateField.java?rev=1516202&r1=1516201&r2=1516202&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/gui/util/JDateField.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/gui/util/JDateField.java Wed Aug 21 16:24:58 2013
@@ -196,7 +196,7 @@ public class JDateField extends JTextFie
try {
dateFormat.parse(getText());
} catch (ParseException e1) {
- requestFocus();
+ requestFocusInWindow();
}
}
}
Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/modifier/gui/ParamModifierGui.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/modifier/gui/ParamModifierGui.java?rev=1516202&r1=1516201&r2=1516202&view=diff
==============================================================================
--- jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/modifier/gui/ParamModifierGui.java (original)
+++ jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/modifier/gui/ParamModifierGui.java Wed Aug 21 16:24:58 2013
@@ -236,7 +236,7 @@ public class ParamModifierGui extends Ab
JOptionPane.showMessageDialog(this, "This field must have a long value!", "Value Required",
JOptionPane.ERROR_MESSAGE);
temp.setText(defaultValue);
- temp.requestFocus();
+ temp.requestFocusInWindow();
}
return longVal;
}
Modified: jmeter/trunk/src/reports/org/apache/jmeter/gui/ReportGuiPackage.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/reports/org/apache/jmeter/gui/ReportGuiPackage.java?rev=1516202&r1=1516201&r2=1516202&view=diff
==============================================================================
--- jmeter/trunk/src/reports/org/apache/jmeter/gui/ReportGuiPackage.java (original)
+++ jmeter/trunk/src/reports/org/apache/jmeter/gui/ReportGuiPackage.java Wed Aug 21 16:24:58 2013
@@ -555,7 +555,7 @@ public final class ReportGuiPackage impl
popup.pack();
popup.show(invoker, e.getX(), e.getY());
popup.setVisible(true);
- popup.requestFocus();
+ popup.requestFocusInWindow();
}
}
Modified: jmeter/trunk/src/reports/org/apache/jmeter/report/gui/tree/ReportTreeListener.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/reports/org/apache/jmeter/report/gui/tree/ReportTreeListener.java?rev=1516202&r1=1516201&r2=1516202&view=diff
==============================================================================
--- jmeter/trunk/src/reports/org/apache/jmeter/report/gui/tree/ReportTreeListener.java (original)
+++ jmeter/trunk/src/reports/org/apache/jmeter/report/gui/tree/ReportTreeListener.java Wed Aug 21 16:24:58 2013
@@ -321,7 +321,7 @@ public class ReportTreeListener implemen
popup.pack();
popup.show(tree, e.getX(), e.getY());
popup.setVisible(true);
- popup.requestFocus();
+ popup.requestFocusInWindow();
}
}
}
Modified: jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1516202&r1=1516201&r2=1516202&view=diff
==============================================================================
--- jmeter/trunk/xdocs/changes.xml (original)
+++ jmeter/trunk/xdocs/changes.xml Wed Aug 21 16:24:58 2013
@@ -409,6 +409,7 @@ Previously the default was 1, which coul
<li><bugzilla>55411</bugzilla> - NativeCommand could be useful elsewhere. Copied code to o.a.jorphan.exec.</li>
<li><bugzilla>55435</bugzilla> - ComboStringEditor could be simplified to make most settings final</li>
<li><bugzilla>55436</bugzilla> - ComboStringEditor should implement ClearGui</li>
+<li><bugzilla>55463</bugzilla> - Component.requestFocus() is discouraged; use requestFocusInWindow() instead</li>
</ul>
<h2>Thanks</h2>