You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/29 17:27:20 UTC
[GitHub] [airflow] dimberman opened a new pull request #9570: Makes multi-namespace mode optional
dimberman opened a new pull request #9570:
URL: https://github.com/apache/airflow/pull/9570
Running the airflow k8sexecutor with multiple namespace abilities
requires creating a ClusterRole which can break existing deployments
---
Make sure to mark the boxes below before creating PR: [x]
- [ ] Description above provides context of the change
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Target Github ISSUE in description if exists
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #9570: Makes multi-namespace mode optional
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9570:
URL: https://github.com/apache/airflow/pull/9570#discussion_r447421319
##########
File path: airflow/utils/dag_processing.py
##########
@@ -63,13 +63,13 @@ class SimpleDag(BaseDag):
:type pickle_id: unicode
"""
- def __init__(self, dag, pickle_id: Optional[str] = None):
- self._dag_id: str = dag.dag_id
- self._task_ids: List[str] = [task.task_id for task in dag.tasks]
- self._full_filepath: str = dag.full_filepath
- self._concurrency: int = dag.concurrency
- self._pickle_id: Optional[str] = pickle_id
- self._task_special_args: Dict[str, Any] = {}
+ def __init__(self, dag, pickle_id=None):
Review comment:
Is it related?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #9570: Makes multi-namespace mode optional
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9570:
URL: https://github.com/apache/airflow/pull/9570#discussion_r447421091
##########
File path: Dockerfile.ci
##########
@@ -224,11 +224,20 @@ ENV AIRFLOW_CI_BUILD_EPOCH=${AIRFLOW_CI_BUILD_EPOCH}
# In case of CI builds we want to pre-install master version of airflow dependencies so that
# We do not have to always reinstall it from the scratch.
# This can be reinstalled from latest master by increasing PIP_DEPENDENCIES_EPOCH_NUMBER.
-# And is automatically reinstalled from the scratch every time patch release of python gets released
-RUN pip install \
- "https://github.com/${AIRFLOW_REPO}/archive/${AIRFLOW_BRANCH}.tar.gz#egg=apache-airflow[${AIRFLOW_EXTRAS}]" \
- --constraint "https://raw.githubusercontent.com/${AIRFLOW_REPO}/${AIRFLOW_BRANCH}/requirements/requirements-python${PYTHON_MAJOR_MINOR_VERSION}.txt" \
- && pip uninstall --yes apache-airflow;
+# And is automatically reinstalled from the scratch every month
Review comment:
Earlier this change was not here, as I did reviews.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman merged pull request #9570: Makes multi-namespace mode optional
Posted by GitBox <gi...@apache.org>.
dimberman merged pull request #9570:
URL: https://github.com/apache/airflow/pull/9570
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #9570: Makes multi-namespace mode optional
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #9570:
URL: https://github.com/apache/airflow/pull/9570#discussion_r447317499
##########
File path: Dockerfile.ci
##########
@@ -224,11 +224,20 @@ ENV AIRFLOW_CI_BUILD_EPOCH=${AIRFLOW_CI_BUILD_EPOCH}
# In case of CI builds we want to pre-install master version of airflow dependencies so that
# We do not have to always reinstall it from the scratch.
# This can be reinstalled from latest master by increasing PIP_DEPENDENCIES_EPOCH_NUMBER.
-# And is automatically reinstalled from the scratch every time patch release of python gets released
-RUN pip install \
- "https://github.com/${AIRFLOW_REPO}/archive/${AIRFLOW_BRANCH}.tar.gz#egg=apache-airflow[${AIRFLOW_EXTRAS}]" \
- --constraint "https://raw.githubusercontent.com/${AIRFLOW_REPO}/${AIRFLOW_BRANCH}/requirements/requirements-python${PYTHON_MAJOR_MINOR_VERSION}.txt" \
- && pip uninstall --yes apache-airflow;
+# And is automatically reinstalled from the scratch every month
Review comment:
I think this brings some old Dockerfile code back which is not valid any more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org