You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Andreas Goss (Jira)" <ji...@apache.org> on 2023/07/19 19:15:00 UTC

[jira] [Commented] (GEOMETRY-144) Review API in "hull" module

    [ https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744759#comment-17744759 ] 

Andreas Goss commented on GEOMETRY-144:
---------------------------------------

I created a pull request on the github project for my suggested change and refactoring of the hull module. Adjusting the code took somehow longer than expected. Please review the code and let me know what you think. As commented earlier, I keep the {{ConvexHull}} interface for now as deleting it completely changed the behavior slightly. 

> Review API in "hull" module
> ---------------------------
>
>                 Key: GEOMETRY-144
>                 URL: https://issues.apache.org/jira/browse/GEOMETRY-144
>             Project: Commons Geometry
>          Issue Type: Task
>            Reporter: Gilles Sadowski
>            Assignee: Gilles Sadowski
>            Priority: Minor
>             Fix For: 1.1
>
>
> Review codes in the [{{commons-geometry-hull}}|https://gitbox.apache.org/repos/asf?p=commons-geometry.git;a=tree;f=commons-geometry-hull;hb=HEAD] module.
> (x) Minimize the public API



--
This message was sent by Atlassian Jira
(v8.20.10#820010)