You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "absurdfarce (via GitHub)" <gi...@apache.org> on 2024/09/05 16:52:02 UTC
[PR] Update driver name after ASF donation [cassandra-gocql-driver]
absurdfarce opened a new pull request, #1817:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1817
Update the driver name to allow servers to clearly distinguish between gocql and cassandra-gocql-driver. Note that something [similar was done](https://github.com/apache/cassandra-java-driver/commit/16260261d3df50fcf24fac1fc2d37896c4a111bf#diff-c45a71e429526ff721761d6a9f3fc0cec3f82a3c44c3f81a1c2ed0157a9f5d70) for the Java driver when it was donated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Update driver name after ASF donation [cassandra-gocql-driver]
Posted by "martin-sucha (via GitHub)" <gi...@apache.org>.
martin-sucha commented on code in PR #1817:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1817#discussion_r1747262584
##########
version.go:
##########
@@ -27,7 +27,7 @@ package gocql
import "runtime/debug"
const (
- mainModule = "github.com/gocql/gocql"
+ mainModule = "github.com/apache/cassandra-gocql-driver"
Review Comment:
It comes from the module name as defined in `go.mod`, which won't change until v2.
The reason why it checks BuildInfo is so that when someone uses a fork with the replace directive, the replaced version/path is used.
We need to keep `mainModule` intact and do
```go
driverName = "github.com/apache/cassandra-gocql-driver"
```
instead of
```go
driverName = mainModule
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Update driver name after ASF donation [cassandra-gocql-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on PR #1817:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1817#issuecomment-2359600868
@tolbertam The test failures here seem to be coming from expired certs for TLS tests. Is fixing that just a matter of getting #1805 merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Update driver name after ASF donation [cassandra-gocql-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on code in PR #1817:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1817#discussion_r1747657293
##########
version.go:
##########
@@ -28,6 +28,7 @@ import "runtime/debug"
const (
mainModule = "github.com/gocql/gocql"
Review Comment:
Note: this string must remain as-is until we rename packages. That won't happen in 1.7.0, however, since the goal of 1.7.0 is just to get an ASF-branded release containing the current contents of the repo out (with some minor modifications).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Update driver name after ASF donation [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on code in PR #1817:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1817#discussion_r1750640671
##########
version.go:
##########
@@ -27,7 +27,7 @@ package gocql
import "runtime/debug"
const (
- mainModule = "github.com/gocql/gocql"
+ mainModule = "github.com/apache/cassandra-gocql-driver"
Review Comment:
Oh wait we're looking at `d.Path` instead of `d.Main`, in that case it is referring to package you're right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Update driver name after ASF donation [cassandra-gocql-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on PR #1817:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1817#issuecomment-2361351154
Thanks @tolbertam! I'm gonna merge #1805 and confirm that that addresses the test failures before calling this one good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Update driver name after ASF donation [cassandra-gocql-driver]
Posted by "tolbertam (via GitHub)" <gi...@apache.org>.
tolbertam commented on PR #1817:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1817#issuecomment-2359679329
That's right @absurdfarce , #1805 aims to resolve the issues around the certs used by the tests expiring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Update driver name after ASF donation [cassandra-gocql-driver]
Posted by "martin-sucha (via GitHub)" <gi...@apache.org>.
martin-sucha commented on PR #1817:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1817#issuecomment-2340120706
Please squash the commits and update the commit message:
https://github.com/apache/cassandra-gocql-driver/blob/trunk/CONTRIBUTING.md#commit-message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Update driver name after ASF donation [cassandra-gocql-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on code in PR #1817:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1817#discussion_r1750648941
##########
version.go:
##########
@@ -27,7 +27,7 @@ package gocql
import "runtime/debug"
const (
- mainModule = "github.com/gocql/gocql"
+ mainModule = "github.com/apache/cassandra-gocql-driver"
Review Comment:
Thanks @joao-r-reis . I kinda like "mainPackage" in this case so I ran with it... if anybody has objections let me know!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Update driver name after ASF donation [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on code in PR #1817:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1817#discussion_r1747294264
##########
version.go:
##########
@@ -27,7 +27,7 @@ package gocql
import "runtime/debug"
const (
- mainModule = "github.com/gocql/gocql"
+ mainModule = "github.com/apache/cassandra-gocql-driver"
Review Comment:
```
if d.Path == mainModule {
driverName = "github.com/apache/cassandra-gocql-driver"
driverVersion = d.Version
if d.Replace != nil {
driverName = d.Replace.Path
driverVersion = d.Replace.Version
}
break
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Update driver name after ASF donation [cassandra-gocql-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on code in PR #1817:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1817#discussion_r1765781110
##########
version.go:
##########
@@ -38,8 +44,8 @@ func init() {
buildInfo, ok := debug.ReadBuildInfo()
Review Comment:
This should be addressed below... let me know if you were thinking of something else @jameshartig !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Update driver name after ASF donation [cassandra-gocql-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on PR #1817:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1817#issuecomment-2362941920
Bah, I mucked this up with the merge commit 🤦 . Closing this out and replacing it with #1824
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Update driver name after ASF donation [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on code in PR #1817:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1817#discussion_r1750636397
##########
version.go:
##########
@@ -27,7 +27,7 @@ package gocql
import "runtime/debug"
const (
- mainModule = "github.com/gocql/gocql"
+ mainModule = "github.com/apache/cassandra-gocql-driver"
Review Comment:
package in the Go land means something different than module, in this case it's referring to the module so I'm fine with keeping it `mainModule` or renaming it to `upstreamModule`, both work for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Update driver name after ASF donation [cassandra-gocql-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on code in PR #1817:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1817#discussion_r1750587781
##########
version.go:
##########
@@ -28,6 +28,7 @@ import "runtime/debug"
const (
mainModule = "github.com/gocql/gocql"
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Update driver name after ASF donation [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on code in PR #1817:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1817#discussion_r1750636397
##########
version.go:
##########
@@ -27,7 +27,7 @@ package gocql
import "runtime/debug"
const (
- mainModule = "github.com/gocql/gocql"
+ mainModule = "github.com/apache/cassandra-gocql-driver"
Review Comment:
package in the Go land means somthing different than module, in this case it's referring to the module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Update driver name after ASF donation [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on code in PR #1817:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1817#discussion_r1750636397
##########
version.go:
##########
@@ -27,7 +27,7 @@ package gocql
import "runtime/debug"
const (
- mainModule = "github.com/gocql/gocql"
+ mainModule = "github.com/apache/cassandra-gocql-driver"
Review Comment:
package in the Go land means somthing different than module, in this case it's referring to the module so I'm fine with keeping it `mainModule` or renaming it to `upstreamModule`, both work for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Update driver name after ASF donation [cassandra-gocql-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce closed pull request #1817: Update driver name after ASF donation
URL: https://github.com/apache/cassandra-gocql-driver/pull/1817
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Update driver name after ASF donation [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on code in PR #1817:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1817#discussion_r1746735989
##########
version.go:
##########
@@ -27,7 +27,7 @@ package gocql
import "runtime/debug"
const (
- mainModule = "github.com/gocql/gocql"
+ mainModule = "github.com/apache/cassandra-gocql-driver"
Review Comment:
Have you tested this? It's using this string to match the dependency path but I'm not sure where the dependency path comes from. If it comes from the actual module name then I don't think this will work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Update driver name after ASF donation [cassandra-gocql-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on code in PR #1817:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1817#discussion_r1750581404
##########
version.go:
##########
@@ -27,7 +27,7 @@ package gocql
import "runtime/debug"
const (
- mainModule = "github.com/gocql/gocql"
+ mainModule = "github.com/apache/cassandra-gocql-driver"
Review Comment:
How about just "mainPacakge"? That has the advantage of matching the terminology in the [runtime/debug docs](https://pkg.go.dev/runtime/debug#BuildInfo)... ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Update driver name after ASF donation [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on code in PR #1817:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1817#discussion_r1750641309
##########
version.go:
##########
@@ -27,7 +27,7 @@ package gocql
import "runtime/debug"
const (
- mainModule = "github.com/gocql/gocql"
+ mainModule = "github.com/apache/cassandra-gocql-driver"
Review Comment:
`mainPackage` or `upstreamPackage` would be more suitable then
##########
version.go:
##########
@@ -27,7 +27,7 @@ package gocql
import "runtime/debug"
const (
- mainModule = "github.com/gocql/gocql"
+ mainModule = "github.com/apache/cassandra-gocql-driver"
Review Comment:
Oh wait we're looking at `d.Path` instead of `d.Main`, in that case it is referring to the package you're right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Update driver name after ASF donation [cassandra-gocql-driver]
Posted by "jameshartig (via GitHub)" <gi...@apache.org>.
jameshartig commented on code in PR #1817:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1817#discussion_r1755158267
##########
version.go:
##########
@@ -38,8 +44,8 @@ func init() {
buildInfo, ok := debug.ReadBuildInfo()
Review Comment:
Since there was some confusion in the PR it would be good to document the point of this code especially as it relates to the replace directive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Update driver name after ASF donation [cassandra-gocql-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on code in PR #1817:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1817#discussion_r1747635126
##########
version.go:
##########
@@ -27,7 +27,7 @@ package gocql
import "runtime/debug"
const (
- mainModule = "github.com/gocql/gocql"
+ mainModule = "github.com/apache/cassandra-gocql-driver"
Review Comment:
🤦 No, really... this is what I get for rushing. Completely agree that "mainModule" is entirely the wrong name here although I still think that there's merit in encapsulating that value in a constant, albeit a better-named constant.
I'll tweak this a bit and see if I can come up with something that (a) is clearer and (b) is very much in the spirit of what's proposed above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Update driver name after ASF donation [cassandra-gocql-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on code in PR #1817:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1817#discussion_r1747637490
##########
version.go:
##########
@@ -27,7 +27,7 @@ package gocql
import "runtime/debug"
const (
- mainModule = "github.com/gocql/gocql"
+ defaultDriverName = "github.com/apache/cassandra-gocql-driver"
Review Comment:
Allows us to contain the default value in a distinct location (i.e. not embedded within the code below) with a _much_ more descriptive name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Update driver name after ASF donation [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on code in PR #1817:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1817#discussion_r1747294264
##########
version.go:
##########
@@ -27,7 +27,7 @@ package gocql
import "runtime/debug"
const (
- mainModule = "github.com/gocql/gocql"
+ mainModule = "github.com/apache/cassandra-gocql-driver"
Review Comment:
```
if d.Path == mainModule {
driverName = "github.com/apache/cassandra-gocql-driver"
driverVersion = d.Version
if d.Replace != nil {
driverName = d.Replace.Path
driverVersion = d.Replace.Version
}
break
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Update driver name after ASF donation [cassandra-gocql-driver]
Posted by "martin-sucha (via GitHub)" <gi...@apache.org>.
martin-sucha commented on code in PR #1817:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1817#discussion_r1750057141
##########
version.go:
##########
@@ -27,7 +27,7 @@ package gocql
import "runtime/debug"
const (
- mainModule = "github.com/gocql/gocql"
+ mainModule = "github.com/apache/cassandra-gocql-driver"
Review Comment:
Perhaps we could rename `mainModule` to `upstreamModule` ?
##########
version.go:
##########
@@ -28,6 +28,7 @@ import "runtime/debug"
const (
mainModule = "github.com/gocql/gocql"
Review Comment:
Please add a note that the string must remain as-is until v2 release as a code comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org